Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the shadow of the table overflows #46644

Merged
merged 1 commit into from Dec 27, 2023

Conversation

Fatpandac
Copy link
Contributor

@Fatpandac Fatpandac commented Dec 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #46634

💡 Background and solution

fix the shadow overflow in the table

📝 Changelog

Language Changelog
🇺🇸 English Fix the issue of table component edge shadow overflows
🇨🇳 Chinese 修复 Table 边缘阴影会超出 Table 高度

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Visual Regression Report for PR #46644 Passed ✅

Target branch: master (e3c4de5)


Congrats! No visual-regression diff found

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3657727:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d4e3ca) 100.00% compared to head (3657727) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46644   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        12120     12120           
  Branches      3217      3217           
=========================================
  Hits         12120     12120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit ae38f1e into ant-design:master Dec 27, 2023
65 of 66 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@Fatpandac Fatpandac deleted the fix/table_shadow branch December 27, 2023 06:48
@zombieJ zombieJ mentioned this pull request Dec 30, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table水平滚动时左侧阴影会超出表格
2 participants