Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize multiple select options style #46646

Merged
merged 1 commit into from Dec 27, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

优化一下 Select 多选时的组件样式,利用 :has 移除相连的选项圆角,不支持 :has 的浏览器整条样式都会作废,不会有变化。

Before
image

After
image

📝 Changelog

Language Changelog
🇺🇸 English Optimize Select style of multiple selection.
🇨🇳 Chinese 优化 Select 组件多选时选项样式。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Visual Regression Report for PR #46646 Passed ✅

Target branch: master (ae38f1e)


Congrats! No visual-regression diff found

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 328.79 KB (+35 B 🔺)
./dist/antd-with-locales.min.js 374.7 KB (+167 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a62d1b:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3c4de5) 100.00% compared to head (7a62d1b) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46646   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        12120     12120           
  Branches      3217      3217           
=========================================
  Hits         12120     12120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit b49fb85 into master Dec 27, 2023
110 checks passed
@MadCcc MadCcc deleted the perf/multiple-selection-style branch December 27, 2023 07:12
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@zombieJ zombieJ mentioned this pull request Dec 30, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants