Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Select support maxCount prop #46667

Merged
merged 18 commits into from Jan 2, 2024
Merged

feat: Select support maxCount prop #46667

merged 18 commits into from Jan 2, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Dec 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English feat: Select support maxCount prop
🇨🇳 Chinese Select 组件支持 maxCount 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Visual Regression Report for PR #46667 Failed ❌

Target branch: feature (276e66c)
View Full Report


image name expected actual diff
layout-fixed.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-fixed.css-var.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-responsive.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-responsive.css-var.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-side-compact.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-side-compact.css-var.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-side-dark.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-side-dark.css-var.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-side-default.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff
layout-side-default.css-var.png feature: 276e66cdaa3e6ddee3a8802af87b733b5eea741a current: pr-46667 diff

Check Full Report for details

@li-jia-nan li-jia-nan changed the title feat: [WIP] Select support maxCount prop feat: Select support maxCount prop Dec 28, 2023
Copy link

socket-security bot commented Dec 28, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-select 14.11.0 None +0 336 kB
rc-cascader 3.21.0 None +1 525 kB zombiej
rc-tree-select 5.17.0 None +1 497 kB zombiej

Signed-off-by: lijianan <574980606@qq.com>
Copy link
Contributor

github-actions bot commented Dec 29, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 330.17 KB (-145 B 🔽)
./dist/antd-with-locales.min.js 376.19 KB (+21 B 🔺)

Copy link

codesandbox-ci bot commented Dec 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd957a8:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1db0daf) 100.00% compared to head (cd957a8) 100.00%.
Report is 13 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46667   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          718       718           
  Lines        12211     12217    +6     
  Branches      3226      3231    +5     
=========================================
+ Hits         12211     12217    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member

MadCcc commented Jan 2, 2024

避免无关改动,这些文件重命名可以新开个 PR

li-jia-nan and others added 2 commits January 2, 2024 10:04
Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>
@li-jia-nan li-jia-nan requested a review from MadCcc January 2, 2024 02:14
Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>
components/select/index.tsx Outdated Show resolved Hide resolved
li-jia-nan and others added 2 commits January 2, 2024 15:59
Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>
@li-jia-nan li-jia-nan requested a review from MadCcc January 2, 2024 08:08
@MadCcc MadCcc merged commit 57521a0 into feature Jan 2, 2024
107 of 108 checks passed
@MadCcc MadCcc deleted the feat-select-maxCount branch January 2, 2024 09:41
Copy link
Contributor

github-actions bot commented Jan 2, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@li-jia-nan
Copy link
Member Author

避免无关改动,这些文件重命名可以新开个 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants