Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QRCode support scanned status #46704

Merged
merged 2 commits into from Dec 30, 2023
Merged

feat: QRCode support scanned status #46704

merged 2 commits into from Dec 30, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Dec 29, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English feat: QRCode support scanned status
🇨🇳 Chinese QRCode 组件支持已扫描状态,顺便补充了台湾和香港国际化

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 29, 2023

Visual Regression Report for PR #46704 Failed ❌

Target branch: feature (968200d)
View Full Report


image name expected actual diff
qr-code-status.png feature: 968200d11eb84de5cdc5aa4d241603fba6acd79c current: pr-46704 diff
qr-code-status.css-var.png feature: 968200d11eb84de5cdc5aa4d241603fba6acd79c current: pr-46704 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Dec 29, 2023

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 330.12 KB (+28 B 🔺)
./dist/antd-with-locales.min.js 376.06 KB (+270 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6352480:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1db0daf) 100.00% compared to head (6352480) 100.00%.
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46704   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          718       718           
  Lines        12211     12212    +1     
  Branches      3226      3227    +1     
=========================================
+ Hits         12211     12212    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member Author

Visual Regression Report for PR #46704 Failed ❌

Target branch: feature (968200d)
View Full Report

这个 diff 是符合预期的

@afc163 afc163 merged commit d7f0fdc into feature Dec 30, 2023
104 of 105 checks passed
@afc163 afc163 deleted the feat-qr-code branch December 30, 2023 06:52
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants