Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ok button of the DatePicker becomes compacted when used with Space.Compact #46769

Merged
merged 7 commits into from Jan 16, 2024

Conversation

Fatpandac
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #46665

💡 Background and solution

给 DatePicker 的 Button 加上了一个 unCompact 以避免受到 Space.Compact 的影响

📝 Changelog

Language Changelog
🇺🇸 English fix ok button of the DatePicker becomes compacted when used with Space.Compact
🇨🇳 Chinese 修复 Space.Compact 与 DatePicker 一起使用导致 DatePicker 的确认按钮样式错误

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Visual Regression Report for PR #46769 Failed ❌

Target branch: master (14af2a7)
View Full Report


image name expected actual diff
qr-code-Popover.dark.css-var.png master: 14af2a77aeeb444295c583cb09f44d777f0ce97c current: pr-46769 diff

Check Full Report for details

Copy link

codesandbox-ci bot commented Jan 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 94650f9:

Sandbox Source
antd reproduction template (forked) Configuration
antd reproduction template (forked) Issue #46665

@Fatpandac Fatpandac requested a review from zombieJ January 4, 2024 01:06
@afc163
Copy link
Member

afc163 commented Jan 15, 2024

冲突了

@Fatpandac
Copy link
Contributor Author

冲突了

处理了

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14af2a7) 100.00% compared to head (94650f9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46769   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12548     12548           
  Branches      3291      3291           
=========================================
  Hits         12548     12548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 77b351f into ant-design:master Jan 16, 2024
61 of 62 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@Fatpandac Fatpandac deleted the fix/datepicker_okButton_style branch January 16, 2024 06:02
@vagusX vagusX mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact 穿透层级导致 DatePicker 的确认按钮圆角错误
4 participants