Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Line Progress use pseudo #46789

Merged
merged 4 commits into from Jan 5, 2024
Merged

refactor: Line Progress use pseudo #46789

merged 4 commits into from Jan 5, 2024

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jan 4, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #46747

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Progress that line border-radius could be override.
🇨🇳 Chinese 修复 Progress 线性模式圆角无法覆盖的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Visual Regression Report for PR #46789 Failed ❌

Target branch: master (f195438)
View Full Report


image name expected actual diff
progress-component-token.png master: f1954384dc9143c1bb088f77622518c06e4d255a current: pr-46789 diff
progress-component-token.css-var.png master: f1954384dc9143c1bb088f77622518c06e4d255a current: pr-46789 diff
progress-gradient-line.png master: f1954384dc9143c1bb088f77622518c06e4d255a current: pr-46789 diff
progress-gradient-line.css-var.png master: f1954384dc9143c1bb088f77622518c06e4d255a current: pr-46789 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 4, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 328.97 KB (+96 B 🔺)
./dist/antd-with-locales.min.js 375.03 KB (+235 B 🔺)

Copy link

codesandbox-ci bot commented Jan 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 850e2af:

Sandbox Source
antd reproduction template (forked) Configuration

@MadCcc
Copy link
Member Author

MadCcc commented Jan 4, 2024

Visual Regression Report for PR #46789 Failed ❌

看起来改后的效果更好些

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aae661b) 100.00% compared to head (850e2af) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46789   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          722       722           
  Lines        12445     12443    -2     
  Branches      3270      3265    -5     
=========================================
- Hits         12445     12443    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 5ee391f into master Jan 5, 2024
105 of 106 checks passed
@MadCcc MadCcc deleted the refactor/line-progress-bg branch January 5, 2024 02:11
Copy link
Contributor

github-actions bot commented Jan 5, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress 支持自定义设置进度条的圆角
2 participants