Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): improve title attribute display #46809

Merged
merged 5 commits into from Jan 9, 2024

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Jan 5, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #46739

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix(radio): improve title attribute display
🇨🇳 Chinese 改进 <Radio /> 的 title 显示

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Visual Regression Report for PR #46809 Passed ✅

Target branch: master (640abc8)


Congrats! No visual-regression diff found

@Wxh16144 Wxh16144 changed the title Wuxh/fix 46739 fix(radio): improve title attribute display Jan 5, 2024
Copy link

codesandbox-ci bot commented Jan 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e2e6bc7:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (640abc8) 100.00% compared to head (e2e6bc7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46809   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          722       722           
  Lines        12444     12444           
  Branches      3265      3265           
=========================================
  Hits         12444     12444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 5, 2024

image diff 看着怎么怪怪的

@zombieJ zombieJ merged commit 84b006c into ant-design:master Jan 9, 2024
62 checks passed
Copy link
Contributor

github-actions bot commented Jan 9, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio.Group options title 配置项不生效
5 participants