New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Button padding token should follow contentFontSize #46901
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Visual Regression Report for PR #46901 Failed ❌
Check Full Report for details |
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 79cf122:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46901 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 722 722
Lines 12444 12441 -3
Branches 3265 3265
=========================================
- Hits 12444 12441 -3 ☔ View full report in Codecov by Sentry. |
@@ -492,7 +492,6 @@ export const prepareComponentToken: GetDefaultToken<'InputNumber'> = (token) => | |||
}); | |||
|
|||
export const formatComponentToken: FormatComponentToken<'InputNumber'> = (token) => ({ | |||
...token, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个方法在 feature 上移到 ./style/token.ts
文件里面了,合并分支的时候冲突了,我顺手改了。cc @MadCcc
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
paddingBlock
token didn't follow customizedcontentFontSize
.contentFontSize
后paddingBlock
不会跟着改变的问题。☑️ Self-Check before Merge