feat: support react 16 lint #46963
feat: support react 16 lint #46963
Conversation
|
|
|
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bc6419e:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46963 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 732 732
Lines 12548 12548
Branches 3291 3291
=========================================
Hits 12548 12548 ☔ View full report in Codecov by Sentry. |
| @@ -2,9 +2,9 @@ import React from 'react'; | |||
| import { PoweroffOutlined } from '@ant-design/icons'; | |||
| import { Button, Flex } from 'antd'; | |||
|
|
|||
| const Text1 = () => '部署'; | |||
| const Text1 = () => <>部署</>; | |||
There was a problem hiding this comment.
这个在执行 npm add @types/react@16 安装 16 的类型后，这地方有报错，所以改的
There was a problem hiding this comment.
这里是故意用组件+返回 string 放到 Button 下面的？可以这样用吗
<Button>
部署
</Button>
|
请完善一下内容。 
|
|
好了，这个不是改组建，不用发版，改的是 ci lint |
|
Background and solution 写一下？未来才容易找到代码改动的原因 |
补充了 |
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
因 5.13.0版本导致
Checkbox.Group在 react 16 版本下有 ts 报错，现增加 react 16/17 环境 antd 组建是否有 ts 错误📝 Changelog
☑️ Self-Check before Merge