support notification pop up from topLeft or bottomRight or bottomLeft #4700

ystarlongzi · 2017-01-24T07:41:58Z

@afc163 @benjycui 调整涉及到的内容如下：

参照 tooltip，引入了 placement 接口，可以在四个方位弹出消息
根据 @afc163 在 pull 4675 处的建议，引入了 bottom 接口，控制消息距离浏览器底部的距离
更新了一些 snapshots

mention-bot · 2017-01-24T07:41:59Z

@ystarlongzi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @yesmeck and @yiminghe to be potential reviewers.

coveralls · 2017-01-24T07:48:40Z

Coverage decreased (-0.9%) to 76.228% when pulling d11c942a3402fa4326e64603a7dd7723b2a24d70 on ystarlongzi:notification-placement into 70188ae on ant-design:feature-2.7.

ystarlongzi · 2017-01-24T08:00:03Z

@afc163 @benjycui

travis 和本地运行 npm run test-all 得到的结果不一致。本地也有报错，但信息如下：

Summary of all failing tests
 FAIL  components/auto-complete/__tests__/ac.test.js
  ● AutoComplete with Custom Input Element Render › AutoComplete with custom Input render perfectly

    expect(received).toBe(expected)
    
    Expected value to be (using ===):
      1
    Received:
      0
      
      at Object.<anonymous> (components/auto-complete/__tests__/ac.test.js:13:45)
      at handle (node_modules/worker-farm/lib/child/index.js:41:8)
      at process.<anonymous> (node_modules/worker-farm/lib/child/index.js:47:3)
      at emitTwo (events.js:106:13)
      at process.emit (events.js:191:7)
      at process.nextTick (internal/child_process.js:719:12)
      at _combinedTickCallback (internal/process/next_tick.js:67:7)
      at process._tickCallback (internal/process/next_tick.js:98:9)

 FAIL  components/form/__tests__/demo.test.js
  ● renders ./components/form/demo/horizontal-login.md correctly

    TypeError: isFieldTouched is not a function
      
      at render (components/form/demo/horizontal-login.md:60:25)
      at node_modules/react-dom/lib/ReactCompositeComponent.js:796:21
      at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:75:12)
      at ReactCompositeComponent._renderValidatedComponentWithoutOwnerOrContext (node_modules/react-dom/lib/ReactCompositeComponent.js:795:25)
      at ReactCompositeComponent._renderValidatedComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:822:32)
      at ReactCompositeComponent.performInitialMount (node_modules/react-dom/lib/ReactCompositeComponent.js:362:30)
      at ReactCompositeComponent.mountComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:258:21)
      at Object.ReactReconciler.mountComponent (node_modules/react-dom/lib/ReactReconciler.js:46:35)
      at ReactCompositeComponent.performInitialMount (node_modules/react-dom/lib/ReactCompositeComponent.js:371:34)
      at ReactCompositeComponent.mountComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:258:21)
      at Object.ReactReconciler.mountComponent (node_modules/react-dom/lib/ReactReconciler.js:46:35)
      at ReactCompositeComponent.performInitialMount (node_modules/react-dom/lib/ReactCompositeComponent.js:371:34)
      at ReactCompositeComponent.mountComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:258:21)
      at Object.ReactReconciler.mountComponent (node_modules/react-dom/lib/ReactReconciler.js:46:35)
      at node_modules/react-dom/lib/ReactServerRendering.js:45:36
      at ReactServerRenderingTransaction.TransactionImpl.perform (node_modules/react-dom/lib/Transaction.js:140:20)
      at renderToStringImpl (node_modules/react-dom/lib/ReactServerRendering.js:43:24)
      at renderToStaticMarkup (node_modules/react-dom/lib/ReactServerRendering.js:83:10)
      at render (node_modules/enzyme/build/render.js:27:52)
      at Object.<anonymous> (tests/shared/demoTest.js:17:66)


Test Suites: 2 failed, 1 skipped, 73 passed, 75 of 76 total
Tests:       2 failed, 10 skipped, 373 passed, 385 total
Snapshots:   315 passed, 315 total
Time:        23.77s

求教关于 Coverage decreased 的失败，我要怎么去解决？

afc163 · 2017-01-24T08:00:25Z

components/auto-complete/__tests__/__snapshots__/demo.test.js.snap

@@ -22,8 +22,9 @@ exports[`test renders ./components/auto-complete/demo/antd.md correctly 1`] = `
          class="ant-select-search ant-select-search--inline">
          <div
            class="ant-select-search__field__wrap">
-            <textarea
-              class="ant-input ant-select-search__field" />


这里不应该修改。

snapshots 是在运行 npm test -- -u 后生成的

afc163 · 2017-01-24T08:01:15Z

非 notification 目录下的 snapshot 不应该有改动。你本地 node_modules 恐怕不是最新的。

ystarlongzi · 2017-01-24T08:04:51Z

确实不是最新的，我再运行下命令。👍

coveralls · 2017-01-24T08:18:46Z

Coverage decreased (-0.9%) to 76.228% when pulling 53d3d4615b9929a735b3a1208f956af36891769a on ystarlongzi:notification-placement into 70188ae on ant-design:feature-2.7.

afc163 · 2017-01-24T08:23:55Z

再 rebase 一下，steps 也不应该有改动。:sweat_smile:

afc163 · 2017-01-24T08:25:14Z

components/notification/demo/placement.md

+      onChange={val => {
+        notification.config({
+            placement: val,
+          });


没对齐。

好的，我调整下。

afc163 · 2017-01-24T08:26:00Z

components/notification/demo/placement.md

+const openNotification = () => {
+  notification.open({
+    message: 'Notification Title',
+    description: 'This is the content of the notification. This is the content of the notification. This is the content of the notification.',


open 这里也支持一下 placement 如何？

好的，我也加下。

@afc163
在实现上支持 placement，然后 demo 里的 open 方法内就不用体现 placement 了吧，因为 demo 里是通过 config 方法修改 placement。

那文档里补充一下。

嗯嗯，好的。

afc163 · 2017-01-24T08:26:58Z

components/notification/demo/placement.md

+            {val}
+          </Option>
+        );
+      })}


{options.map(val => <Option key={val}>{val}</Option>)}

好的，我调整下。

afc163 · 2017-01-24T09:32:27Z

rebase 一下，最好不要出现 Merge branch 的提交。

coveralls · 2017-01-24T09:35:03Z

Coverage decreased (-1.04%) to 76.05% when pulling b1855d5850ba828696c36d693a2aa206e7de1085 on ystarlongzi:notification-placement into f4e887b on ant-design:feature-2.7.

afc163 · 2017-01-24T09:36:56Z

还有，补一下用例吧，真是辛苦了。。

ystarlongzi · 2017-01-24T09:42:12Z

嗯嗯，好的，我也研究下 rebase 的用法。

afc163 · 2017-01-25T13:18:50Z

@ystarlongzi 节前有时间完成么？春节前我们要发 2.7 ~

ystarlongzi · 2017-01-26T04:08:06Z

@afc163
嗯嗯，在了，刚到家。
现在我有个难点还是 rebase 的使用，看了些教程和文档，但是实际操作起来还是摸不着头脑。
我先写下用例吧。

afc163 · 2017-01-26T04:28:52Z

$ git checkout feature-2.7
$ git pull --rebase git@github.com:ant-design/ant-design.git feature-2.7   // 把 feature-2.7 更新到最新
$ git checkout notification-placement
$ git rebase feature-2.7

然后如果冲突了。用 git status 查看冲突文件，本地编辑手动解决所有冲突。

$ git add {解决完冲突的文件}
$ git rebase --continue // 继续 rebase，如果冲突返回上面继续解决
$ git push origin notification-placement -f  // 强制 push 到远程分支

coveralls · 2017-01-26T05:19:03Z

Coverage decreased (-0.9%) to 75.755% when pulling a7b2e3f on ystarlongzi:notification-placement into fd233cf on ant-design:feature-2.7.

benjycui · 2017-01-26T06:07:40Z

空了可以看下 pro git 之类的书籍。

RaoHai · 2017-01-26T06:33:18Z

@ystarlongzi
https://www.atlassian.com/git/tutorials/rewriting-history

2. update doc 3. support `placement` arguments in `open` method

ystarlongzi · 2017-01-26T08:33:01Z

@afc163 @benjycui 谢谢！假期会再了解下关于 git 的内容。
@RaoHai 谢谢提供的文章！

coveralls · 2017-01-26T08:37:14Z

Coverage increased (+1.9%) to 78.516% when pulling 546a789 on ystarlongzi:notification-placement into fd233cf on ant-design:feature-2.7.

yesmeck · 2017-01-27T06:13:47Z

components/notification/index.zh-CN.md

-| top        | 消息距离顶部的位置 | Number                     | 24px         |
+| placement  | 弹出位置，可选 `topLeft` `topRight` `bottomLeft` `bottomRight` | string | topRight |
+| top        | 消息从顶部弹出时，距离顶部的位置 | Number            | 24px        |
+| bottom     | 消息从底部弹出时，距离底部的位置 | Number            | 24px        |


number 小写，默认值是 24px 还是 24 ？如果是 24px 的话那应该是 string。

是 24，我调整下。

coveralls · 2017-01-27T09:07:08Z

Coverage increased (+1.9%) to 78.516% when pulling c6b0780 on ystarlongzi:notification-placement into fd233cf on ant-design:feature-2.7.

coveralls · 2017-01-27T09:11:05Z

Coverage increased (+1.9%) to 78.516% when pulling c6b0780 on ystarlongzi:notification-placement into fd233cf on ant-design:feature-2.7.

afc163 reviewed Jan 24, 2017

View reviewed changes

afc163 changed the title ~~support notification pop up from topLeft or bottomRight or bottomLeft~~ [WIP] support notification pop up from topLeft or bottomRight or bottomLeft Jan 25, 2017

ystarlongzi added 4 commits January 26, 2017 13:07

update snapshots

9b91fe5

update snapshots

6b467da

support notification pop up from topLeft or bottomRight or bottomLeft

0f82d1f

update snapshots

a7b2e3f

1. add test

546a789

2. update doc 3. support `placement` arguments in `open` method

afc163 changed the title ~~[WIP] support notification pop up from topLeft or bottomRight or bottomLeft~~ support notification pop up from topLeft or bottomRight or bottomLeft Jan 26, 2017

afc163 approved these changes Jan 26, 2017

View reviewed changes

yesmeck reviewed Jan 27, 2017

View reviewed changes

ystarlongzi added 2 commits January 27, 2017 16:58

update doc

85fdda2

update doc.

c6b0780

afc163 merged commit aadf623 into ant-design:feature-2.7 Jan 27, 2017

afc163 mentioned this pull request Oct 23, 2017

Feature antd 3.0/spin indicator #7971

Closed

afc163 added the ❓FAQ issues would be discussed a lot label Oct 26, 2018

afc163 mentioned this pull request Oct 26, 2018

Add alwaysShowTooltip to set ToolTip shown #12819

Closed

orzyyyy mentioned this pull request Oct 27, 2018

fix 12810 Pagination itemRender Typescript error #12814

Closed

10 tasks

orzyyyy mentioned this pull request Dec 10, 2018

Fix #13529 input group compact border color issues #13550

Merged

10 tasks

afc163 mentioned this pull request Mar 8, 2019

fix config-provide prefixCls props for modal #15271

Closed

13 tasks

orzyyyy mentioned this pull request Oct 20, 2019

feat: Add allowClear to TextArea #19310

Merged

14 tasks

afc163 mentioned this pull request Nov 13, 2019

Improve buttons code antvis/gatsby-theme-antv#20

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support notification pop up from topLeft or bottomRight or bottomLeft #4700

support notification pop up from topLeft or bottomRight or bottomLeft #4700

ystarlongzi commented Jan 24, 2017

mention-bot commented Jan 24, 2017

coveralls commented Jan 24, 2017

ystarlongzi commented Jan 24, 2017

afc163 Jan 24, 2017

ystarlongzi Jan 24, 2017

afc163 commented Jan 24, 2017 •

edited

Loading

ystarlongzi commented Jan 24, 2017

coveralls commented Jan 24, 2017

afc163 commented Jan 24, 2017

afc163 Jan 24, 2017

ystarlongzi Jan 24, 2017

afc163 Jan 24, 2017 •

edited

Loading

ystarlongzi Jan 24, 2017

ystarlongzi Jan 24, 2017

afc163 Jan 24, 2017

ystarlongzi Jan 24, 2017

afc163 Jan 24, 2017

ystarlongzi Jan 24, 2017

afc163 commented Jan 24, 2017

coveralls commented Jan 24, 2017

afc163 commented Jan 24, 2017

ystarlongzi commented Jan 24, 2017

afc163 commented Jan 25, 2017 •

edited

Loading

ystarlongzi commented Jan 26, 2017

afc163 commented Jan 26, 2017 •

edited

Loading

coveralls commented Jan 26, 2017

benjycui commented Jan 26, 2017

RaoHai commented Jan 26, 2017 •

edited

Loading

ystarlongzi commented Jan 26, 2017

coveralls commented Jan 26, 2017

yesmeck Jan 27, 2017

ystarlongzi Jan 27, 2017 •

edited

Loading

coveralls commented Jan 27, 2017

coveralls commented Jan 27, 2017

support notification pop up from topLeft or bottomRight or bottomLeft #4700

support notification pop up from topLeft or bottomRight or bottomLeft #4700

Conversation

ystarlongzi commented Jan 24, 2017

mention-bot commented Jan 24, 2017

coveralls commented Jan 24, 2017

ystarlongzi commented Jan 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afc163 commented Jan 24, 2017 • edited Loading

ystarlongzi commented Jan 24, 2017

coveralls commented Jan 24, 2017

afc163 commented Jan 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afc163 Jan 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afc163 commented Jan 24, 2017

coveralls commented Jan 24, 2017

afc163 commented Jan 24, 2017

ystarlongzi commented Jan 24, 2017

afc163 commented Jan 25, 2017 • edited Loading

ystarlongzi commented Jan 26, 2017

afc163 commented Jan 26, 2017 • edited Loading

coveralls commented Jan 26, 2017

benjycui commented Jan 26, 2017

RaoHai commented Jan 26, 2017 • edited Loading

ystarlongzi commented Jan 26, 2017

coveralls commented Jan 26, 2017

Choose a reason for hiding this comment

ystarlongzi Jan 27, 2017 • edited Loading

Choose a reason for hiding this comment

coveralls commented Jan 27, 2017

coveralls commented Jan 27, 2017

afc163 commented Jan 24, 2017 •

edited

Loading

afc163 Jan 24, 2017 •

edited

Loading

afc163 commented Jan 25, 2017 •

edited

Loading

afc163 commented Jan 26, 2017 •

edited

Loading

RaoHai commented Jan 26, 2017 •

edited

Loading

ystarlongzi Jan 27, 2017 •

edited

Loading