Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Select should show scrollbar when overflowed #47050

Merged
merged 1 commit into from Jan 19, 2024
Merged

fix: Select should show scrollbar when overflowed #47050

merged 1 commit into from Jan 19, 2024
+1 −1

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jan 19, 2024 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #47045

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select that scrollbar is not displayed when there are few options.
🇨🇳 Chinese 修复 Select 组件在选项较少时不显示滚动条的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024 •
edited

Preview Is ready

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 285.56 KB (+1 B 🔺)
./dist/antd.min.css 66.23 KB
./dist/antd.dark.min.css 67.47 KB
./dist/antd.compact.min.css 66.18 KB
./dist/antd.variable.min.css 66.77 KB

@MadCcc MadCcc merged commit e18bc84 into 4.x-stable Jan 19, 2024
97 of 99 checks passed
@MadCcc MadCcc deleted the fix/select-scroll branch January 19, 2024 03:42
@afc163 afc163 mentioned this pull request Feb 8, 2024
Closed
@afc163 afc163 mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jia-nan li-jia-nan li-jia-nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MadCcc @li-jia-nan