Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Button add tokens #47075

Merged
merged 2 commits into from Jan 26, 2024
Merged

Conversation

madocto
Copy link
Contributor

@madocto madocto commented Jan 20, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close: #46249

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Button add defaultHoverBg, defaultHoverColor, defaultHoverBorderColor, defaultActiveBg, defaultActiveColor and defaultActiveBorderColor tokens.
🇨🇳 Chinese Button 添加 defaultHoverBgdefaultHoverColordefaultHoverBorderColordefaultActiveBgdefaultActiveColordefaultActiveBorderColor 六个 token。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 20, 2024

Visual Regression Report for PR #47075 Passed ✅

Target branch: feature (bb6b475)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Jan 20, 2024

Preview Is ready

Copy link

codesandbox-ci bot commented Jan 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7eef4a0:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7173e80) 100.00% compared to head (593403e) 100.00%.
Report is 32 commits behind head on feature.

❗ Current head 593403e differs from pull request most recent head 7eef4a0. Consider uploading reports for the commit 7eef4a0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47075   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12548     12554    +6     
  Branches      3291      3297    +6     
=========================================
+ Hits         12548     12554    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/button/style/token.ts Outdated Show resolved Hide resolved
components/button/style/token.ts Outdated Show resolved Hide resolved
components/button/style/token.ts Outdated Show resolved Hide resolved
components/button/style/token.ts Outdated Show resolved Hide resolved
components/button/style/token.ts Outdated Show resolved Hide resolved
components/button/style/token.ts Outdated Show resolved Hide resolved
components/button/style/token.ts Outdated Show resolved Hide resolved
components/button/style/token.ts Outdated Show resolved Hide resolved
components/button/style/token.ts Outdated Show resolved Hide resolved
@madocto madocto requested a review from MadCcc January 26, 2024 04:06
@MadCcc MadCcc merged commit 3c477ee into ant-design:feature Jan 26, 2024
65 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@madocto madocto deleted the feat-default-button-token branch January 26, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants