Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Segmented value type support generics #47091

Merged
merged 7 commits into from Jan 27, 2024

Conversation

madocto
Copy link
Contributor

@madocto madocto commented Jan 22, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close: #46234

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Segmented value type support generics.
🇨🇳 Chinese Segmented value 类型支持泛型。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Visual Regression Report for PR #47091 Passed ✅

Target branch: feature (a62d7ec)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Preview Is ready

Copy link

socket-security bot commented Jan 22, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-segmented@2.3.0 environment +11 5.63 MB afc163

View full report↗︎

Copy link

codesandbox-ci bot commented Jan 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5549f8b:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a62d7ec) 100.00% compared to head (5549f8b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47091   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12560     12561    +1     
  Branches      3296      3296           
=========================================
+ Hits         12560     12561    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Jan 22, 2024

把 demo 代码也修改掉吧,展示如何使用这个泛型。

@crazyair
Copy link
Member

react-component/segmented#181 我这个改完了,还没合

Signed-off-by: afc163 <afc163@gmail.com>
@madocto madocto requested a review from afc163 January 26, 2024 15:54
@afc163 afc163 merged commit 7e4bca3 into ant-design:feature Jan 27, 2024
61 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants