Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): support virtual components.body #47098

Merged
merged 7 commits into from Jan 26, 2024

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Jan 22, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

react-component/table#1069

📝 Changelog

Language Changelog
🇺🇸 English Table support components.body when virtual
🇨🇳 Chinese Table 支持 virtual 下的 components.body

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Visual Regression Build for PR #47098 Failed ❌

Potential causes:

  • upstream workflow status: failure upstream job link
  • download report artifact status: failure
  • report upload status: skipped

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Preview Is ready

@linxianxi linxianxi changed the base branch from master to feature January 22, 2024 09:43
@linxianxi linxianxi changed the title Feat table virtual components feat(Table): support virtual components.body Jan 22, 2024
Copy link

socket-security bot commented Jan 22, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-table@7.38.0 Transitive: environment +14 6.22 MB afc163, benjycui, dxq613, ...6 more

View full report↗︎

Copy link

codesandbox-ci bot commented Jan 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e089321:

Sandbox Source
antd reproduction template (forked) Configuration

package.json Show resolved Hide resolved
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b9ced5) 100.00% compared to head (e089321) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47098   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12558     12558           
  Branches      3294      3294           
=========================================
  Hits         12558     12558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit a62d7ec into ant-design:feature Jan 26, 2024
60 of 62 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants