Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): props show-count param display incorrect in space compact mode #47112

Conversation

huiliangShen
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #46872

💡 Background and solution

📝 Changelog

Input wrapped by <span class="${componentCls}-affix-wrapper">...</span> when Input Component props show-count. The original css not consider &:not(${componentCls}-compact-last-item), so we need to fix this case.

Language Changelog
🇺🇸 English fix: Input props show-count param display incorrect in space compact mode
🇨🇳 Chinese 修复Input传入show-count参数后在Space.Compact下的样式错误

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Visual Regression Report for PR #47112 Failed ❌

Target branch: master (8963725)
View Full Report


image name expected actual diff
space-compact-debug.compact.png master: 8963725d388593c6bf106cabcaf858612c9560e5 current: pr-47112 diff
space-compact-debug.compact.css-var.png master: 8963725d388593c6bf106cabcaf858612c9560e5 current: pr-47112 diff
space-compact-debug.dark.png master: 8963725d388593c6bf106cabcaf858612c9560e5 current: pr-47112 diff
space-compact-debug.dark.css-var.png master: 8963725d388593c6bf106cabcaf858612c9560e5 current: pr-47112 diff
space-compact-debug.default.png master: 8963725d388593c6bf106cabcaf858612c9560e5 current: pr-47112 diff
space-compact-debug.default.css-var.png master: 8963725d388593c6bf106cabcaf858612c9560e5 current: pr-47112 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Preview Is ready

Copy link

codesandbox-ci bot commented Jan 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b3e4308:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f87e10) 100.00% compared to head (b3e4308) 100.00%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12554     12554           
  Branches      3294      3294           
=========================================
  Hits         12554     12554           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member

MadCcc commented Jan 26, 2024

Please leave a test demo for visual Regression.

@huiliangShen
Copy link
Contributor Author

huiliangShen commented Jan 26, 2024

Please leave a test demo for visual Regression.

Is that means write a case at space->demo->compact-debug.tsx this file?

@afc163 afc163 merged commit 62df041 into ant-design:master Jan 27, 2024
61 of 62 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

MadCcc pushed a commit that referenced this pull request Jan 29, 2024
… mode (#47112)

* fix(input):use show-count param display incorrect in space compact mode

* update compact-debug file

---------

Co-authored-by: banruo <shl@dataqin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input 配置 addonBefore、showCount 后接 Button 按钮,样式展示待优化
3 participants