Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QRCode): Fix the issue where the background color and font color … #47128

Merged
merged 5 commits into from Jan 26, 2024

Conversation

kampiu
Copy link
Contributor

@kampiu kampiu commented Jan 23, 2024

…of the QR code component do not synchronize with the theme in dark mode

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#47126

💡 Background and solution

Refer to other components to handle changes in style based on tokens, and use tokens at the QR code component layer to calculate transparency.

📝 Changelog

Language Changelog
🇺🇸 English Fix mask background color and font color in dark mode
🇨🇳 Chinese 修复深色模式下的遮罩背景颜色和字体颜色

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

…of the QR code component do not synchronize with the theme in dark mode
Copy link

stackblitz bot commented Jan 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Visual Regression Report for PR #47128 Failed ❌

Target branch: master (119f8aa)
View Full Report


image name expected actual diff
config-provider-locale.dark.png master: 119f8aaf794104ad81a0a531615eb0ab89aeed15 current: pr-47128 diff
config-provider-locale.dark.css-var.png master: 119f8aaf794104ad81a0a531615eb0ab89aeed15 current: pr-47128 diff
qr-code-status.dark.png master: 119f8aaf794104ad81a0a531615eb0ab89aeed15 current: pr-47128 diff
qr-code-status.dark.css-var.png master: 119f8aaf794104ad81a0a531615eb0ab89aeed15 current: pr-47128 diff

Check Full Report for details

@kampiu
Copy link
Contributor Author

kampiu commented Jan 23, 2024

Preview under default theme

image

Preview under dark themes

image

Can the document site add a theme switching function, or have I not noticed the existence of related functions?

Copy link

codesandbox-ci bot commented Jan 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 81ee16c:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (119f8aa) 100.00% compared to head (81ee16c) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12553     12553           
  Branches      3294      3294           
=========================================
  Hits         12553     12553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kampiu kampiu requested a review from MadCcc January 25, 2024 05:44
@kampiu kampiu requested a review from MadCcc January 26, 2024 07:19
@afc163 afc163 merged commit 63e5e13 into ant-design:master Jan 26, 2024
61 of 62 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

MadCcc pushed a commit that referenced this pull request Jan 29, 2024
#47128)

* fix(QRCode): Fix the issue where the background color and font color of the QR code component do not synchronize with the theme in dark mode

* fix(QRCode): Update test snapshot

* fix(QRCode): Remove inline styles, adjust style handling, and regenerate test snapshots

* fix(QRCode): Fix the issue of unreasonable style handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants