Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InputNumber support changeOnWheel #47158

Merged
merged 1 commit into from Jan 26, 2024
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jan 26, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English InputNumber support changeOnWheel to allow changing by mouse wheel.
🇨🇳 Chinese InputNumber 组件支持 changeOnWheel 属性,以启用鼠标滚轮控制。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Visual Regression Report for PR #47158 Failed ❌

Target branch: feature (bb6b475)
View Full Report


image name expected actual diff
avatar-component-token.dark.css-var.png feature: bb6b475f22eaad41da26888cf21f41310239eaaf current: pr-47158 diff

Check Full Report for details

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-input-number@9.0.0 Transitive: environment +12 5.6 MB

View full report↗︎

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 331.21 KB (-72 B 🔽)
./dist/antd-with-locales.min.js 377.4 KB (+77 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fd6f098:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb6b475) 100.00% compared to head (fd6f098) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12560     12560           
  Branches      3296      3296           
=========================================
  Hits         12560     12560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 4def7a2 into feature Jan 26, 2024
108 of 109 checks passed
@MadCcc MadCcc deleted the feat/InputNumber-changeOnWheel branch January 26, 2024 06:05
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants