Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm PageHeader locale #47163

Merged
merged 2 commits into from Jan 26, 2024
Merged

chore: rm PageHeader locale #47163

merged 2 commits into from Jan 26, 2024

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English chore: rm PageHeader locale
🇨🇳 Chinese chore: 移除了多语言中 PageHeader 组件相关的部分

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Visual Regression Report for PR #47163 Failed ❌

Target branch: master (119f8aa)
View Full Report


image name expected actual diff
avatar-component-token.dark.css-var.png master: 119f8aaf794104ad81a0a531615eb0ab89aeed15 current: pr-47163 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 26, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 331.16 KB (-136 B 🔽)
./dist/antd-with-locales.min.js 377.05 KB (-341 B 🔽)

Copy link

codesandbox-ci bot commented Jan 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 18234ba:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa137e9) 100.00% compared to head (18234ba) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47163   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12553     12596   +43     
  Branches      3294      3315   +21     
=========================================
+ Hits         12553     12596   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 5955c7e into master Jan 26, 2024
105 of 106 checks passed
@li-jia-nan li-jia-nan deleted the rm-pageHeader branch January 26, 2024 08:00
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

MadCcc pushed a commit that referenced this pull request Jan 29, 2024
* chore: rm PageHeader locale

* test: fix test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants