Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input.Search width 1px smaller than Input #47193

Merged
merged 1 commit into from Jan 27, 2024
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 27, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #47150

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input.Search width 1px smaller than Input.
🇨🇳 Chinese 修复 Input.Search 宽度比 Input 少 1px 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 27, 2024

Visual Regression Report for PR #47193 Failed ❌

Target branch: master (25eda83)
View Full Report


image name expected actual diff
auto-complete-certain-category.compact.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-certain-category.compact.css-var.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-certain-category.dark.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-certain-category.dark.css-var.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-certain-category.default.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-certain-category.default.css-var.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-form-debug.compact.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-form-debug.compact.css-var.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-form-debug.dark.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff
auto-complete-form-debug.dark.css-var.png master: 25eda833fbad6d86e28e70559e1a009fe6dd1812 current: pr-47193 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 27, 2024

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 331.46 KB (-15 B 🔽)
./dist/antd-with-locales.min.js 377.12 KB (-121 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d0dd45d:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25eda83) 100.00% compared to head (d0dd45d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12557     12557           
  Branches      3295      3295           
=========================================
  Hits         12557     12557           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 201f1fc into master Jan 27, 2024
110 of 111 checks passed
@afc163 afc163 deleted the fix/Search-width-1px branch January 27, 2024 15:18
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input.Search lost 1px compared to other components
2 participants