Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Drawer motion style #47194

Merged
merged 12 commits into from Jan 27, 2024
Merged

refactor: Drawer motion style #47194

merged 12 commits into from Jan 27, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 27, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

ref #46881

💡 Background and solution

  • 重构了 Drawer 的动画样式代码,提取了重复代码,体积上应该有一些收益。

比起 #46881 ,基本没有修改原本的动画效果,只是重构代码。

📝 Changelog

Language Changelog
🇺🇸 English Refactor Drawer motion style code.
🇨🇳 Chinese 重构简化 Drawer 的动画代码。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 27, 2024

Visual Regression Report for PR #47194 Passed ✅

Target branch: master (25eda83)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Jan 27, 2024

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 331.41 KB (-40 B 🔽)
./dist/antd-with-locales.min.js 376.98 KB (-10 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a22af4a:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25eda83) 100.00% compared to head (a22af4a) 100.00%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12557     12563    +6     
  Branches      3295      3295           
=========================================
+ Hits         12557     12563    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 8eab513 into master Jan 27, 2024
114 checks passed
@afc163 afc163 deleted the refactor/drawer-motion-style branch January 27, 2024 15:35
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@li-jia-nan
Copy link
Member

preview 链接打不开,看不到效果呢

MadCcc pushed a commit that referenced this pull request Jan 29, 2024
* refactor: rewrite drawer motion style code

* style: improve Drawer motion

* refactor: simpify style code

* test: fix test coverage

* test: fix test coverage

* chore: remove !important

* chore: revert refactor code

* refactor: simpify style code

* refactor: simpify style code

* refactor: simpify style code

* refactor: simpify style code

* revert: move distance to 100%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants