Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve inner pagination padding #47231

Merged
merged 6 commits into from Feb 2, 2024
Merged

Conversation

qmhc
Copy link
Contributor

@qmhc qmhc commented Jan 30, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

None.

💡 Background and solution

Before:

image

image

After:

image

image

📝 Changelog

Language Changelog
🇺🇸 English improve inner pagination padding
🇨🇳 Chinese 改进内部分页器的内边距

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Visual Regression Report for PR #47231 Failed ❌

Target branch: master (ac33262)
View Full Report


image name expected actual diff
transfer-component-token.compact.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-component-token.compact.css-var.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-component-token.dark.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-component-token.dark.css-var.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-component-token.default.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-component-token.default.css-var.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-large-data.compact.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-large-data.compact.css-var.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-large-data.dark.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff
transfer-large-data.dark.css-var.png master: ac332621118ea6b8f01541e9e63692077a8517e5 current: pr-47231 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Preview Is ready

Copy link

codesandbox-ci bot commented Jan 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c53859:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (057e81f) 100.00% compared to head (6c53859) 100.00%.
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12563     12563           
  Branches      3296      3296           
=========================================
  Hits         12563     12563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

li-jia-nan
li-jia-nan previously approved these changes Jan 30, 2024
@MadCcc
Copy link
Member

MadCcc commented Jan 30, 2024

image
这个没对齐的感觉

@li-jia-nan
Copy link
Member

确实

@qmhc
Copy link
Contributor Author

qmhc commented Jan 30, 2024

image 这个没对齐的感觉

是的,这个在改之前也发现的,但是应该是 Pagination 的问题,所以不包含在这个 PR 里面。

@li-jia-nan
Copy link
Member

before:
image

after:
image

@MadCcc MadCcc merged commit 82b1f77 into ant-design:master Feb 2, 2024
61 of 62 checks passed
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants