Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Tabs api description #47356

Merged
merged 3 commits into from
Feb 7, 2024
Merged

docs: update Tabs api description #47356

merged 3 commits into from
Feb 7, 2024

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English docs: update Tabs api description
🇨🇳 Chinese docs: update Tabs api description

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Visual Regression Report for PR #47356 Passed ✅

Target branch: feature (cfe7226)


Congrats! No visual-regression diff found

@afc163
Copy link
Member

afc163 commented Feb 5, 2024

原来的 API 越看越难受,还得到处解释什么时候生效。最好是:

<Tabs type="card" editable={{ addIcon, removeIcon }} />

Copy link
Contributor

github-actions bot commented Feb 5, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.3 KB
./dist/antd-with-locales.min.js 379.34 KB

@li-jia-nan
Copy link
Member Author

原来的 API 越看越难受,还得到处解释什么时候生效。最好是:

<Tabs type="card" editable={{ addIcon, removeIcon }} />

@MadCcc 要不开个投票?

Copy link

codesandbox-ci bot commented Feb 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8ae066b:

Sandbox Source
antd reproduction template (forked) Configuration

components/tabs/index.en-US.md Outdated Show resolved Hide resolved
components/tabs/index.en-US.md Outdated Show resolved Hide resolved
li-jia-nan and others added 2 commits February 7, 2024 10:07
Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfe7226) 100.00% compared to head (8ae066b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12589     12589           
  Branches      3294      3294           
=========================================
  Hits         12589     12589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 9bf2b2c into feature Feb 7, 2024
105 checks passed
@MadCcc MadCcc deleted the icon-docs branch February 7, 2024 03:23
Copy link
Contributor

github-actions bot commented Feb 7, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* docs: update Tabs description

* Update components/tabs/index.en-US.md

Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>

* Update components/tabs/index.en-US.md

Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>

---------

Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: MadCcc <madccc@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants