fix: Dropdown should respect trigger's disabled prop #47363
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #47363 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
MadCcc
reviewed
Feb 6, 2024
size-limit report 📦
|
zombieJ
reviewed
Feb 6, 2024
components/dropdown/dropdown.tsx
Outdated
| }); | ||
| }; | ||
| if (typeof disabled !== 'undefined') { | ||
| dropdownTriggerProps.disabled = disabled; |
There was a problem hiding this comment.
HOC 和 context 都不会生效:
<ConfigProvider componentDisabled>
<Dropdown><Button /></Dropdown>
</ConfigProvider>直接到 feature 里把这个 disabled 传导去了要不？
There was a problem hiding this comment.
要设置一下 Dropdown 的 disabled:
<ConfigProvider componentDisabled>
<Dropdown menu={{ items }} disabled={false}>
<Button />
</Dropdown>
</ConfigProvider>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 746 746
Lines 12996 12997 +1
Branches 3412 3413 +1
=========================================
+ Hits 12996 12997 +1 ☔ View full report in Codecov by Sentry. |
afc163
force-pushed
the
fix/dropdown-trigger-disabled
branch
2 times, most recently
from
0d8a91c
to
a8e25a1
Compare
li-jia-nan
previously approved these changes
Feb 7, 2024
li-jia-nan
reviewed
Feb 7, 2024
afc163
force-pushed
the
fix/dropdown-trigger-disabled
branch
from
a8e25a1
to
c59e3c1
Compare
li-jia-nan
approved these changes
Feb 7, 2024
crazyair
approved these changes
Feb 7, 2024
kiner-tang
approved these changes
Feb 8, 2024
afc163
force-pushed
the
fix/dropdown-trigger-disabled
branch
from
c59e3c1
to
14a3155
Compare
afc163
force-pushed
the
fix/dropdown-trigger-disabled
branch
from
14a3155
to
6497874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
disabledprop not working when it is Dropdown's children.disabled属性不生效的问题。☑️ Self-Check before Merge