Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datePicker arrow out of bound #47389

Merged
merged 2 commits into from Feb 7, 2024
Merged

fix: datePicker arrow out of bound #47389

merged 2 commits into from Feb 7, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 7, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Before

截屏2024-02-07 15 14 57

After

Kapture 2024-02-07 at 15 02 47

📝 Changelog

Language Changelog
🇺🇸 English Fix DatePicker & TimePicker arrow position not consider panel border radius distance.
🇨🇳 Chinese 修复 DatePicker 与 TimePicker 弹出面板箭头没有考虑面板本身圆角的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 7, 2024

👁 Visual Regression Report for PR #47389 Passed ✅

🎯 Target branch: master (a4c4c47)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

crazyair
crazyair previously approved these changes Feb 7, 2024
Copy link

socket-security bot commented Feb 7, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-picker@4.1.1 Transitive: environment +17 7.6 MB 07akioni, afc163, lixuan, ...3 more

View full report↗︎

Copy link
Contributor

github-actions bot commented Feb 7, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.39 KB (+8 B 🔺)
./dist/antd-with-locales.min.js 379.34 KB (-21 B 🔽)

kiner-tang
kiner-tang previously approved these changes Feb 7, 2024
@zombieJ zombieJ dismissed stale reviews from kiner-tang and crazyair via 9e4d0ff February 7, 2024 07:22
Copy link

codesandbox-ci bot commented Feb 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e4d0ff:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4c4c47) 100.00% compared to head (9e4d0ff) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12611     12593   -18     
  Branches      3308      3298   -10     
=========================================
- Hits         12611     12593   -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 52fdbb4 into master Feb 7, 2024
106 checks passed
@afc163 afc163 deleted the picker-arrow branch February 7, 2024 12:29
Copy link
Contributor

github-actions bot commented Feb 7, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@MadCcc MadCcc mentioned this pull request Feb 10, 2024
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* fix: datePicker arrow out of bound

* chore: use logic prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants