Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version #4751

Merged
merged 2 commits into from
Feb 8, 2017
Merged

add version #4751

merged 2 commits into from
Feb 8, 2017

Conversation

yiminghe
Copy link
Contributor

@yiminghe yiminghe commented Feb 3, 2017

support

import { version } from 'antd'; 

@mention-bot
Copy link

@yiminghe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163 to be a potential reviewer.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.804% when pulling cee7966 on version into f786f60 on master.

@afc163
Copy link
Member

afc163 commented Feb 3, 2017

dist/antd.js 里也要有。

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.804% when pulling e1777a7 on version into f786f60 on master.

@benjycui
Copy link
Contributor

benjycui commented Feb 6, 2017

这个和 babel-plugin-import 会冲突吧? cc @sorrycc

@benjycui
Copy link
Contributor

benjycui commented Feb 6, 2017

补上 antd/lib/version 应该就可以了。

@afc163 afc163 assigned ddcat1115 and unassigned afc163 Feb 6, 2017
afc163
afc163 approved these changes Feb 6, 2017
Copy link
Member

@afc163 afc163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesmeck
Copy link
Member

yesmeck commented Feb 6, 2017

这个创建一个 components/version.ts,在 components/index.tsxexport 是不是好一点。

@afc163
Copy link
Member

afc163 commented Feb 6, 2017

b619f01

以前加过,不过需要使用时配置 json-loader,就去掉了。

可以尝试把 components/version.ts 动态生成出来。

@afc163 afc163 assigned ddcat1115 and unassigned ddcat1115 Feb 7, 2017
@yesmeck
Copy link
Member

yesmeck commented Feb 7, 2017

是的,自动更新 components/version.ts 简单点,或者也不需要自动更新,发布前自动检查下 version.ts 跟 package.json 的版本是否一致也可以。

@afc163
Copy link
Member

afc163 commented Feb 7, 2017

要手动改就比较蛋疼。

@ddcat1115 ddcat1115 merged commit dbae84c into master Feb 8, 2017
@afc163 afc163 deleted the version branch February 8, 2017 06:53
@yesmeck
Copy link
Member

yesmeck commented Feb 13, 2017

这个和 babel-plugin-import 会冲突吧?

确实在启用 style 的情况下会有问题,因为 version 没有 style。

@yiminghe
Copy link
Contributor Author

添加空的 style 支持

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants