Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CP support Menu expandIcon #47561

Merged
merged 9 commits into from Feb 26, 2024
Merged

feat: CP support Menu expandIcon #47561

merged 9 commits into from Feb 26, 2024

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: CP support Menu expandIcon
🇨🇳 Chinese feat: CP support Menu expandIcon

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 23, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 23, 2024

👁 Visual Regression Report for PR #47561 Passed ✅

🎯 Target branch: feature (f46af93)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Feb 23, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.79 KB (+346 B 🔺)
./dist/antd-with-locales.min.js 379.51 KB (-298 B 🔽)

Copy link

codesandbox-ci bot commented Feb 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

components/menu/menu.tsx Outdated Show resolved Hide resolved
components/menu/menu.tsx Outdated Show resolved Hide resolved
components/menu/menu.tsx Outdated Show resolved Hide resolved
components/menu/menu.tsx Outdated Show resolved Hide resolved
components/menu/menu.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f46af93) to head (c669f86).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47561   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12618     12620    +2     
  Branches      3307      3310    +3     
=========================================
+ Hits         12618     12620    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit b28b0d8 into feature Feb 26, 2024
105 checks passed
@MadCcc MadCcc deleted the menu-expandIcon branch February 26, 2024 01:55
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* feat: CP support Menu expandIcon

* fix: test case fix

* fix: test case fix

* fix: fix

* fix: fix

* chore: rename

* type: add type

---------

Signed-off-by: lijianan <574980606@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants