Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: virtual list prefixCls not working #47639

Merged
merged 2 commits into from Feb 29, 2024
Merged

fix: virtual list prefixCls not working #47639

merged 2 commits into from Feb 29, 2024

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Feb 28, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

react-component/table#1082

📝 Changelog

Language Changelog
🇺🇸 English fix: virtual list prefixCls not working
🇨🇳 Chinese 修复virtual table 中 prefixCls 无效

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 28, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 28, 2024

👁 Visual Regression Report for PR #47639 Passed ✅

🎯 Target branch: feature (183746a)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@yoyo837
Copy link
Contributor Author

yoyo837 commented Feb 28, 2024

@Wxh16144 我蹭个PR

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 334.19 KB (+144 B 🔺)
./dist/antd-with-locales.min.js 379.83 KB (-50 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (183746a) to head (a8cbea0).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47639   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12637     12637           
  Branches      3323      3323           
=========================================
  Hits         12637     12637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837 yoyo837 merged commit 2156ed4 into feature Feb 29, 2024
107 checks passed
@yoyo837 yoyo837 deleted the rc-table-upgrade branch February 29, 2024 01:45
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* fix: virtual list prefixCls not working

* update test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants