Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support focus options #47664

Merged
merged 5 commits into from Mar 1, 2024
Merged

feat: Support focus options #47664

merged 5 commits into from Mar 1, 2024

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Mar 1, 2024 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Select Checkbox Radio DatePicker TreeSelect Cascader support focus options
🇨🇳 Chinese Select Checkbox Radio DatePicker TreeSelect Cascader 支持 focus options

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@crazyair crazyair changed the base branch from master to feature March 1, 2024 03:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited

👁 Visual Regression Report for PR #47664 Passed ✅

🎯 Target branch: feature (6928fbc)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited

Preview is ready

@crazyair crazyair marked this pull request as draft March 1, 2024 03:36
@li-jia-nan
Copy link
Member

api 文档还需要更新一下

@socket-security Socket Security
Copy link

socket-security bot commented Mar 1, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ant-design/colors@7.0.2 None +1 272 kB madccc
npm/@ant-design/compatible@5.1.2 environment +8 6.45 MB madccc
npm/@ant-design/cssinjs@1.18.4 environment +7 5.64 MB zombiej
npm/@ant-design/happy-work-theme@1.0.0 Transitive: environment +10 6.03 MB zombiej
npm/@ant-design/icons@5.3.1 environment +9 18.7 MB madccc
npm/@ant-design/react-slick@1.0.2 environment +5 1.54 MB afc163
npm/@ant-design/tools@18.0.2 filesystem Transitive: environment, eval, network, shell, unsafe +13 12.8 MB madccc
npm/@antv/g6@4.8.24 None 0 7.99 MB iaaron
npm/@babel/eslint-plugin@7.23.5 Transitive: environment, filesystem +4 3.11 MB nicolo-ribaudo
npm/@biomejs/biome@1.5.3 shell 0 118 kB dominionl
npm/@codesandbox/sandpack-react@2.13.5 eval Transitive: environment +3 6.15 MB danilowoz
npm/@ctrl/tinycolor@3.6.1 None 0 249 kB scttcper
npm/@dnd-kit/core@6.1.0 environment +3 5.95 MB clauderic
npm/@dnd-kit/modifiers@7.0.0 environment +4 6 MB clauderic
npm/@dnd-kit/sortable@8.0.0 environment +4 6.18 MB clauderic
npm/@dnd-kit/utilities@3.2.2 environment +1 405 kB clauderic
npm/@emotion/react@11.11.4 environment +3 1.19 MB emotion-release-bot
npm/@emotion/server@11.11.0 environment 0 48.7 kB emotion-release-bot
npm/@ianvs/prettier-plugin-sort-imports@4.1.1 environment, unsafe Transitive: filesystem +2 8.51 MB ianvs
npm/@madccc/duplicate-package-checker-webpack-plugin@1.0.0 None +4 1.49 MB madccc
npm/@qixian.cs/github-contributors-list@2.0.1 network Transitive: environment +2 4.84 MB chenshuai2144
npm/@rc-component/color-picker@1.5.2 Transitive: environment +8 5.72 MB madccc
npm/@rc-component/mutate-observer@1.1.0 environment +7 5.4 MB zombiej
npm/@rc-component/tour@1.12.3 Transitive: environment +10 5.78 MB afc163
npm/@rc-component/trigger@1.18.3 environment +9 5.71 MB zombiej
npm/@size-limit/file@11.0.2 None 0 3.43 kB ai
npm/@stackblitz/sdk@1.9.0 None 0 180 kB fvsch
npm/@testing-library/dom@9.3.4 environment +6 3.55 MB testing-library-bot
npm/@testing-library/jest-dom@6.4.2 Transitive: environment, filesystem, network, shell +10 7.85 MB testing-library-bot
npm/@testing-library/react@14.2.1 environment +11 14.2 MB testing-library-bot
npm/@testing-library/user-event@14.5.2 Transitive: environment +7 3.99 MB testing-library-bot
npm/@types/ali-oss@6.16.11 None 0 42.2 kB types
npm/@types/fs-extra@11.0.4 None 0 36.8 kB types
npm/@types/gtag.js@0.0.19 None 0 8.85 kB types
npm/@types/http-server@0.12.4 None 0 4.58 kB types
npm/@types/inquirer@9.0.7 None 0 73.6 kB types
npm/@types/isomorphic-fetch@0.0.39 None 0 2.77 kB types
npm/@types/jest-axe@3.5.9 None +2 146 kB types
npm/@types/jest-environment-puppeteer@5.0.6 Transitive: unsafe +1 15.5 kB types
npm/@types/jest-image-snapshot@6.4.0 None +3 157 kB types
npm/@types/jest@29.5.12 None +1 139 kB types
npm/@types/jquery@3.5.29 None 0 1.12 MB types
npm/@types/jsdom@21.1.6 None 0 21.9 kB types
npm/@types/minimist@1.2.5 None 0 6.27 kB types
npm/@types/nprogress@0.2.3 None 0 4.83 kB types
npm/@types/pixelmatch@5.2.6 None 0 7.87 kB types
npm/@types/pngjs@6.0.4 None 0 5.45 kB types
npm/@types/prismjs@1.26.3 None 0 19.2 kB types
npm/@types/progress@2.0.7 None 0 6.51 kB types
npm/@types/react-copy-to-clipboard@5.0.7 None +1 427 kB types
npm/@types/react-highlight-words@0.16.7 None +1 429 kB types
npm/@types/react-resizable@3.0.7 None +1 430 kB types
npm/@types/react@18.2.60 None 0 423 kB types
npm/@types/tar@6.1.11 None 0 29.8 kB types
npm/@types/throttle-debounce@5.0.2 None 0 6.48 kB types
npm/@types/warning@3.0.3 None 0 2.71 kB types
npm/@typescript-eslint/eslint-plugin@7.1.0 Transitive: environment, filesystem +6 5.71 MB jameshenry
npm/@typescript-eslint/parser@7.1.0 Transitive: environment, filesystem +4 3.1 MB jameshenry
npm/ali-oss@6.20.0 filesystem +2 4.37 MB fengmk2
npm/antd-img-crop@4.21.0 Transitive: environment +2 4.87 MB nanxiaobei
npm/antd-style@3.6.1 environment +10 6.47 MB arvinxx
npm/antd-token-previewer@2.0.8 Transitive: environment +11 20.2 MB madccc
npm/chalk@4.1.2 None +1 42.1 kB sindresorhus
npm/cheerio@1.0.0-rc.12 None 0 558 kB feedic
npm/circular-dependency-plugin@5.2.2 None 0 10.5 kB theron
npm/classnames@2.5.1 None 0 23.6 kB jedwatson
npm/cross-env@7.0.3 environment 0 29.1 kB kentcdodds
npm/cross-fetch@4.0.0 network +1 195 kB lquixada
npm/crypto@1.0.1 None 0 778 B ehsalazar
npm/dayjs@1.11.10 None 0 664 kB iamkun
npm/dekko@0.2.1 filesystem 0 8.91 kB benjycui
npm/dumi-plugin-color-chunk@1.1.0 Transitive: environment, network +25 13.9 MB wxh16144
npm/dumi@2.3.0-beta.7 Transitive: environment, network +22 13.5 MB peachscript
npm/esbuild-loader@4.0.3 None 0 34.1 kB hirokiosame
npm/eslint-config-airbnb@19.0.4 Transitive: environment, filesystem, unsafe +12 6.48 MB ljharb
npm/eslint-plugin-compat@4.2.0 filesystem Transitive: environment +6 3.15 MB amilajack
npm/eslint-plugin-import@2.29.1 filesystem, unsafe Transitive: environment +5 4.35 MB ljharb
npm/eslint-plugin-jsx-a11y@6.8.0 Transitive: environment, filesystem +6 4.11 MB ljharb
npm/eslint-plugin-lodash@7.4.0 filesystem Transitive: environment +5 4.82 MB idok
npm/eslint-plugin-markdown@3.0.1 Transitive: environment, filesystem +4 3.11 MB eslintbot
npm/eslint-plugin-react@7.33.2 filesystem Transitive: environment +5 3.98 MB ljharb
npm/eslint-plugin-unicorn@51.0.1 Transitive: environment, filesystem +5 3.76 MB sindresorhus
npm/eslint@8.57.0 environment, filesystem +3 3.08 MB eslintbot
npm/fetch-jsonp@1.3.0 None 0 12.4 kB camsong
npm/fs-extra@11.2.0 None +1 59.6 kB ryanzim
npm/gh-pages@6.1.1 filesystem, shell +2 99.5 kB tschaub
npm/glob@10.3.10 Transitive: environment +1 888 kB isaacs
npm/html2sketch@1.0.2 network 0 1.87 MB arvinxx
npm/http-server@14.1.1 environment, filesystem, network +3 221 kB thornjad
npm/husky@9.0.11 environment, filesystem, shell 0 3.61 kB typicode
npm/identity-obj-proxy@3.0.0 None 0 8.38 kB keyanzhang
npm/immer@10.0.3 environment 0 620 kB mweststrate
npm/inquirer@9.2.15 None +4 1.55 MB danielchatfield, mischah, ruyadorno, ...1 more
npm/is-ci@3.0.1 None 0 3.81 kB sibiraj-s
npm/isomorphic-fetch@3.0.0 Transitive: network +1 169 kB mattandrews
npm/jest-axe@8.0.0 None +2 63.1 kB nickcolley
npm/jest-canvas-mock@2.5.2 None 0 112 kB atool
npm/jest-environment-jsdom@29.7.0 Transitive: eval, filesystem, network, shell, unsafe +2 3.14 MB simenb
npm/jest-environment-node@29.7.0 unsafe 0 9.37 kB simenb
npm/jest-image-snapshot@6.4.0 environment, filesystem, shell Transitive: network +8 7.9 MB amexopensource
npm/jest-puppeteer@10.0.1 None +1 335 kB neoziro
npm/jest@29.7.0 Transitive: environment, filesystem, network, shell +2 5.7 MB simenb
npm/jquery@3.7.1 None 0 1.25 MB timmywil
npm/jsdom@24.0.0 eval, filesystem, network, shell, unsafe 0 3.11 MB domenic
npm/jsonml-to-react-element@1.1.11 Transitive: eval, filesystem, network, shell, unsafe +2 3.16 MB benjycui
npm/jsonml.js@0.1.0 Transitive: eval, filesystem, network, shell, unsafe +1 3.14 MB benjycui
npm/lint-staged@15.2.2 Transitive: environment, filesystem, shell +2 340 kB okonet
npm/lunar-typescript@1.7.4 None 0 1.34 MB 6tail
npm/mockdate@3.0.5 None 0 13.8 kB boblauer
npm/node-fetch@3.3.2 network 0 107 kB node-fetch-bot
npm/node-notifier@10.0.1 environment, filesystem, network, shell +1 5.69 MB mikaelb
npm/nprogress@0.2.0 None 0 31.8 kB rstacruz
npm/open@10.0.4 environment 0 48.5 kB sindresorhus
npm/pixelmatch@5.3.0 None +1 666 kB mourner
npm/pngjs@7.0.0 None 0 650 kB lukeapage
npm/prettier-plugin-jsdoc@1.3.0 Transitive: environment, filesystem, unsafe +1 8.62 MB hosseinmdeveloper
npm/pretty-format@29.7.0 None 0 60.7 kB simenb
npm/prismjs@1.29.0 None 0 2.05 MB rundevelopment
npm/progress@2.0.3 None 0 15.5 kB turbopope
npm/puppeteer@22.3.0 None 0 331 kB google-wombot, mathias
npm/qrcode.react@3.1.0 Transitive: environment +1 388 kB zpao
npm/rc-cascader@3.22.0 environment +13 6.74 MB zombiej
npm/rc-checkbox@3.2.0 Transitive: environment +7 5.41 MB zombiej
npm/rc-collapse@3.7.2 Transitive: environment +8 5.55 MB madccc
npm/rc-dialog@9.4.0 environment +8 5.57 MB zombiej
npm/rc-drawer@7.1.0 environment +8 5.55 MB afc163
npm/rc-dropdown@4.1.0 Transitive: environment +10 5.76 MB madccc
npm/rc-field-form@1.42.0 environment +6 5.65 MB zombiej
npm/rc-footer@0.6.8 Transitive: environment +5 5.16 MB afc163
npm/rc-image@7.6.0 Transitive: environment +9 5.73 MB zombiej
npm/rc-input-number@9.0.0 Transitive: environment +8 5.54 MB madccc
npm/rc-input@1.4.3 Transitive: environment +7 5.46 MB madccc
npm/rc-mentions@2.10.1 environment +13 6.19 MB madccc
npm/rc-menu@9.12.4 environment +10 5.98 MB madccc
npm/rc-motion@2.9.0 Transitive: environment +7 5.5 MB madccc
npm/rc-notification@5.3.0 environment +8 5.58 MB madccc
npm/rc-pagination@4.0.4 environment +7 5.56 MB madccc
npm/rc-picker@4.1.5 Transitive: environment +11 7.27 MB 07akioni, afc163, lixuan, ...3 more
npm/rc-progress@3.5.1 environment +7 5.44 MB zombiej
npm/rc-rate@2.12.0 Transitive: environment +7 5.43 MB afc163
npm/rc-resize-observer@1.4.0 environment +7 5.42 MB zombiej
npm/rc-segmented@2.3.0 environment +8 5.54 MB afc163
npm/rc-select@14.12.0 environment +11 6.18 MB zombiej
npm/rc-slider@10.5.0 environment +7 5.54 MB madccc
npm/rc-steps@6.0.1 Transitive: environment +7 5.44 MB zombiej
npm/rc-switch@4.1.0 Transitive: environment +7 5.41 MB afc163
npm/rc-table@7.42.0 environment +9 5.95 MB zombiej
npm/rc-tabs@14.0.0 environment +12 6.19 MB afc163
npm/rc-textarea@1.6.3 environment +9 5.56 MB madccc
npm/rc-tooltip@6.1.3 Transitive: environment +10 5.77 MB afc163
npm/rc-tree-select@5.18.0 environment +13 6.71 MB zombiej
npm/rc-tree@5.8.5 environment +10 6.03 MB zombiej
npm/rc-tween-one@3.0.6 Transitive: environment +4 5.19 MB jljsj33
npm/rc-upload@4.5.2 Transitive: environment +7 5.45 MB zombiej
npm/rc-util@5.38.2 Transitive: environment +5 5.36 MB afc163, benjycui, dahong, ...6 more
npm/rc-virtual-list@3.11.4 environment +8 5.55 MB zombiej
npm/react-copy-to-clipboard@5.1.0 Transitive: environment +2 372 kB nkbt
npm/react-countup@6.5.0 Transitive: environment +1 350 kB mapkeji
npm/react-draggable@4.4.6 Transitive: environment +2 5.06 MB strml
npm/react-fast-marquee@1.6.4 Transitive: environment +2 4.86 MB justin-chu
npm/react-highlight-words@0.20.0 environment +1 1.92 MB sergei-startsev
npm/react-infinite-scroll-component@6.1.0 Transitive: environment +2 576 kB ankeetmaini
npm/react-intersection-observer@9.8.1 Transitive: environment +2 4.96 MB thebuilder
npm/react-resizable@3.0.5 Transitive: environment +3 5.18 MB strml
npm/react-router-dom@6.22.2 environment +2 5.7 MB mjackson
npm/react-sticky-box@2.0.5 Transitive: environment +1 334 kB danielberndt
npm/remark-cli@12.0.0 None +1 34.2 kB wooorm
npm/remark-gfm@4.0.0 None 0 21.4 kB wooorm
npm/remark-html@16.0.1 None 0 17 kB wooorm
npm/remark-lint-no-undefined-references@4.2.1 None 0 20.9 kB wooorm
npm/remark-lint@9.1.2 None 0 6.64 kB wooorm
npm/remark-preset-lint-recommended@6.1.3 None +2 38.5 kB wooorm
npm/remark@15.0.1 None 0 15.7 kB wooorm
npm/runes2@1.1.4 environment 0 120 kB bluelovers
npm/scroll-into-view-if-needed@3.1.0 None 0 44.8 kB stipsan
npm/sharp@0.33.2 environment +1 510 kB lovell
npm/simple-git@3.22.0 shell 0 887 kB steveukx
npm/throttle-debounce@5.0.0 None 0 83.1 kB niksy

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Mar 1, 2024 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@ant-design/tools@18.0.2, npm/@biomejs/biome@1.5.3, npm/core-js@3.34.0, npm/sharp@0.33.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited

size-limit report 📦

Path Size
./dist/antd.min.js 334.3 KB (+152 B 🔺)
./dist/antd-with-locales.min.js 380.08 KB (+104 B 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 1, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3e2496c) to head (a92fe9c).

Additional details and impacted files 
@@            Coverage Diff            @@
##           feature    #47664   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12637     12637           
  Branches      3323      3323           
=========================================
  Hits         12637     12637

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazyair crazyair marked this pull request as ready for review March 1, 2024 06:00
@crazyair
Copy link
Member Author

crazyair commented Mar 1, 2024

api 文档还需要更新一下

Input 之前就有，但是也没写，全局都是一样的

image

zombieJ
zombieJ previously approved these changes Mar 1, 2024
View reviewed changes
@zombieJ
Copy link
Member

zombieJ commented Mar 1, 2024

@SocketSecurity ignore npm/@ant-design/tools@18.0.2
@SocketSecurity ignore npm/core-js@3.34.0
@SocketSecurity ignore npm/sharp@0.33.2
@SocketSecurity ignore npm/@biomejs/biome@1.5.3

@li-jia-nan li-jia-nan merged commit 650d4a3 into feature Mar 1, 2024
105 checks passed
@li-jia-nan li-jia-nan deleted the support-focus-options branch March 1, 2024 07:05
@crazyair crazyair mentioned this pull request Mar 1, 2024
Closed
@xrkffgg xrkffgg mentioned this pull request Mar 1, 2024
Merged
@xliez xliez mentioned this pull request Mar 11, 2024
Merged
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
@crazyair @li-jia-nan
feat: Support focus options (ant-design#47664)
69fc540 
* feat: support focus options

* feat: picker

* feat: 回滚

---------

Co-authored-by: lijianan <574980606@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crazyair @li-jia-nan @zombieJ