demo: Form + Modal 优化 #47677
Closed
demo: Form + Modal 优化 #47677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #47677 Failed ❌
Check Full Report for details |
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
afc163
reviewed
Mar 3, 2024
| })} | ||
| </div> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
这个封装还是比较高阶，导致这个例子的复杂度会上升，用户如果有一些自定义需求会不太改的动。
There was a problem hiding this comment.
复杂的这个组建是可复用的，我觉得还好。主要是 Modal 能支持打开加载，关闭卸载，用户使用时会变的简单很多
afc163
reviewed
Mar 3, 2024
| > | ||
| {node} | ||
| </Form> | ||
| )} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge