feat: Tag support aria-* in closable #47678

kiner-tang · 2024-03-02T01:39:44Z

🤔 This is a ...

🔗 Related issue link

📝 [RFC] Support aria-* in closable #47188

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	Tag support aria-* in closable
🇨🇳 Chinese	标签支持在 closable 中配置 aria-*

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

stackblitz · 2024-03-02T01:39:47Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2024-03-02T01:39:56Z

github-actions · 2024-03-02T01:39:56Z

👁 Visual Regression Report for PR #47678 Failed ❌

🎯 Target branch: feature (fe83792)
📖 View Full Report ↗︎

Image name	Expected	Actual	Diff
`tag-basic.compact.png`
`tag-basic.compact.css-var.png`
`tag-basic.dark.png`
`tag-basic.dark.css-var.png`
`tag-basic.default.png`
`tag-basic.default.css-var.png`

Check Full Report for details

github-actions · 2024-03-02T01:42:07Z

size-limit report 📦

Path	Size
`./dist/antd.min.js`	336.21 KB (+48 B 🔺)
`./dist/antd-with-locales.min.js`	383.32 KB (+22 B 🔺)

codesandbox-ci · 2024-03-02T01:46:46Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov · 2024-03-02T01:59:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (100fa29) to head (3bb1871).
Report is 3 commits behind head on feature.

Additional details and impacted files

@@            Coverage Diff             @@
##           feature    #47678    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          742       743     +1     
  Lines        12817     12947   +130     
  Branches      3363      3414    +51     
==========================================
+ Hits         12817     12947   +130

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/tag/index.tsx

components/_util/hooks/useClosable.tsx

components/tag/index.tsx

components/tag/__tests__/__snapshots__/demo-extend.test.ts.snap

components/_util/hooks/useClosable.tsx

socket-security · 2024-03-26T06:20:29Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

kiner-tang · 2024-03-26T06:34:05Z

@SocketSecurity ignore npm/fsevents@1.2.13

Signed-off-by: kiner-tang <1127031143@qq.com>

…nt-design into feature-aria-in-tag

* fix: consistent with the tag component, the processing state uses colorInfo token. (#47695) Signed-off-by: pfdgithub <pfdgithub@users.noreply.github.com> * feat: Notification support aria-* in closable (#47710) * feat: Notification support aria-* in closable * feat: optimize code * Cascader support option render (#47727) * feat: done * feat: doc * feat: improve Transfer `key` type (#47879) * feat: add Transfer's key type * docs: update prop * fix: key type * fix: cycle dependency * chore: update size limit (#47903) Signed-off-by: Amumu <yoyo837@hotmail.com> * chore: update size limit (#47904) * feat: add Uzbek(latn) locale (#47899) * feat: add Uzbek(latn) locale * size-limit * Update docs/react/i18n.zh-CN.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: Amumu <yoyo837@hotmail.com> --------- Signed-off-by: Amumu <yoyo837@hotmail.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: lijianan <574980606@qq.com> * feat: support `showSorterTooltip.target` for Table sorters (#47409) * Added `sorterTooltipTarget` prop for table sorters * demo updated * updated snapshot * updated snapshot * moved table tooltip target to `showSorterTooltip` * fix * updated docs * empty commit * updated version in docs --------- Co-authored-by: Alina Andrieieva <Alina_Andrieieva@epam.com> * feat: CP support FloatButton.Group closeIcon (#47953) * Typography support collapse (#47264) * feat: typograohy support collapse * feat: snap * feat: test * feat: 单测不符合预期 * feat: test * feat: 恢复 * feat: test * feat: test * feat: 修改命名 * feat: 代码优化 * feat: 添加控制台提示 * feat: snap * feat: symbol support function * feat: snap * fix: text * feat: snap * feat: api 修改 * feat: key 修改 * feat: 去掉参数 * feat: lint * feat: snap * feat: test * feat: use 2 * feat: review * feat: test * chore: part of it * chore: fix auto collapse logic * feat: 修改 doc 单测 * feat: doc * test: update testcase * docs: add more --------- Co-authored-by: 二货机器人 <smith3816@gmail.com> * feat: Table support onScroll event (#47986) * feat: Popover can be closed by ESC when trigger is focus or click (#47928) * feat:Add keydown event to handle escape * fix * fix:use exact same logic with popconfirm * fix:move same logic from popconfirm to popover * fix * fix * add test * fix * fix * fix * test size-limit * fix * fix popconfirm test * fix * fix --------- Co-authored-by: afc163 <afc163@gmail.com> * chore: update size-limit (#48014) * feat: steps support for circular progress bar (#47940) * feat: steps support for circular progress bar * Update components/progress/index.zh-CN.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/progress.tsx Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/__tests__/index.test.tsx Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/demo/circle-steps.tsx Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> * Update circle-steps.tsx * Update components/progress/progress.tsx Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update package.json * Update components/progress/demo/circle-steps.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: lijianan <574980606@qq.com> --------- Signed-off-by: lijianan <574980606@qq.com> Co-authored-by: lijianan <574980606@qq.com> Co-authored-by: afc163 <afc163@gmail.com> * demo: update Progress demo (#48052) * demo: update Progress demo * fix: fix * fix: fix * fix: fix * fix: update snap * chore: update size-limit (#48098) * feat: add Scrollbar css token (#48109) * feat: add Scrollbar css token * docs: update docs * feat: upgrade react-slick (#48093) * feat: upgrade react-slick * test: update snapshots * test: update snapshots --------- Co-authored-by: lijianan <574980606@qq.com> * Revert "feat: add Scrollbar css token (#48109)" (#48115) This reverts commit d0cc93b. * feat: Input.OTP component support (#48076) * chore: basic control * chore: input instad * docs: update demo * chore: adjust operation interactive * chore: lock selection * chore: fix patch logic * chore: merge logic * chore: patch autoFocus * test: update snapshot * test: add test case * test: coverage * chore: update size limit * docs: update docs * test: fix test case * chore: update comment * refactor: change to length * chore: blur all * chore: size limit * fix: Upload remove margin using flex display (#48091) * fix: remove upload margin with flex * fix * use support not * fix * feat: copy support async (#48123) * feat: copy support async * feat: add test * feat: doc * feat: snap * feat: add loading * feat: 恢复 try * feat: 判断是否是 Error * feat: throw error * feat: 为了醋包了饺子 * feat: remove code * feat: add loading test * fix: test * fix: icon import way * chore: improve test case code * chore: improve test case code --------- Co-authored-by: afc163 <afc163@gmail.com> * feat: Table add `rowHoverable` to disable hover interaction (#48112) * feat: Tag support aria-* in closable (#47678) * feat: Tag support aria-* in closable * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * refactor: useClosable * chore: modal * fix: check logic * chore: clean up * feat: optimize code * feat: optimize code --------- Signed-off-by: kiner-tang <1127031143@qq.com> Co-authored-by: 二货机器人 <smith3816@gmail.com> --------- Signed-off-by: pfdgithub <pfdgithub@users.noreply.github.com> Signed-off-by: Amumu <yoyo837@hotmail.com> Signed-off-by: lijianan <574980606@qq.com> Signed-off-by: kiner-tang <1127031143@qq.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pfdgithub <pfdgithub@users.noreply.github.com> Co-authored-by: kiner-tang <1127031143@qq.com> Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com> Co-authored-by: lijianan <574980606@qq.com> Co-authored-by: 章鱼怪 <hi.madocto@gmail.com> Co-authored-by: Amumu <yoyo837@hotmail.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: Alina Andrieieva <emilialina@list.ru> Co-authored-by: Alina Andrieieva <Alina_Andrieieva@epam.com> Co-authored-by: 二货机器人 <smith3816@gmail.com> Co-authored-by: Cooper <73218815+CooperHash@users.noreply.github.com> Co-authored-by: yykoypj <601924094@qq.com>

* feat: Tag support aria-* in closable * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * refactor: useClosable * chore: modal * fix: check logic * chore: clean up * feat: optimize code * feat: optimize code --------- Signed-off-by: kiner-tang <1127031143@qq.com> Co-authored-by: 二货机器人 <smith3816@gmail.com>

feat: Tag support aria-* in closable

9d466ab

kiner-tang requested review from zombieJ and li-jia-nan March 2, 2024 01:39

zombieJ reviewed Mar 4, 2024

View reviewed changes

components/tag/index.tsx Outdated Show resolved Hide resolved

kiner-tang added 2 commits March 5, 2024 14:45

feat: optimize code

0373ff4

feat: optimize code

bf53d01

afc163 reviewed Mar 5, 2024

View reviewed changes

components/_util/hooks/useClosable.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 5, 2024

View reviewed changes

components/_util/hooks/useClosable.tsx Outdated Show resolved Hide resolved

kiner-tang added 7 commits March 5, 2024 16:28

feat: optimize code

3dff94c

feat: optimize code

de36dfa

feat: optimize code

a250b16

feat: optimize code

cde4640

Merge branch 'feature' into feature-aria-in-tag

5f0c5f9

feat: optimize code

da0e6f7

Merge branch 'feature' into feature-aria-in-tag

8a2bbef

zombieJ reviewed Mar 7, 2024

View reviewed changes

components/_util/hooks/useClosable.tsx Outdated Show resolved Hide resolved

kiner-tang added 6 commits March 13, 2024 18:02

feat: optimize code

953e1f8

feat: optimize code

5c34513

feat: optimize code

41dc590

feat: optimize code

c618c97

Merge branch 'feature' into feature-aria-in-tag

f70566d

feat: optimize code

68045d6

kiner-tang requested a review from zombieJ March 14, 2024 00:30

zombieJ reviewed Mar 14, 2024

View reviewed changes

components/_util/hooks/useClosable.tsx Outdated Show resolved Hide resolved

feat: optimize code

0b6f77e

kiner-tang requested a review from zombieJ March 25, 2024 10:11

zombieJ reviewed Mar 25, 2024

View reviewed changes

components/tag/index.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Mar 25, 2024

View reviewed changes

components/tag/__tests__/__snapshots__/demo-extend.test.ts.snap Show resolved Hide resolved

zombieJ reviewed Mar 25, 2024

View reviewed changes

components/_util/hooks/useClosable.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Mar 25, 2024

View reviewed changes

components/_util/hooks/useClosable.tsx Outdated Show resolved Hide resolved

kiner-tang added 6 commits March 25, 2024 21:07

feat: optimize code

ce6ce43

feat: optimize code

f50f0e9

feat: optimize code

73c98d5

feat: optimize code

432fc86

Merge branch 'feature' into feature-aria-in-tag

3525551

feat: optimize code

ff2203e

feat: optimize code

945f2dc

kiner-tang requested a review from zombieJ March 26, 2024 07:24

kiner-tang and others added 8 commits March 28, 2024 19:09

Merge branch 'feature' into feature-aria-in-tag

6662f34

Signed-off-by: kiner-tang <1127031143@qq.com>

refactor: useClosable

b15872c

chore: modal

833fad2

fix: check logic

d3cc132

chore: clean up

418fc1b

Merge branch 'feature-aria-in-tag' of https://github.com/ant-design/a…

d662ded

…nt-design into feature-aria-in-tag

feat: optimize code

a0f6c76

feat: optimize code

3bb1871

li-jia-nan approved these changes Mar 29, 2024

View reviewed changes

MadCcc merged commit 506753c into feature Mar 31, 2024
104 of 105 checks passed

MadCcc deleted the feature-aria-in-tag branch March 31, 2024 03:56

MadCcc mentioned this pull request Mar 31, 2024

docs: changelog 5.16.0 #48191

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Tag support aria-* in closable #47678

feat: Tag support aria-* in closable #47678

kiner-tang commented Mar 2, 2024

stackblitz bot commented Mar 2, 2024

github-actions bot commented Mar 2, 2024 •

edited

github-actions bot commented Mar 2, 2024 •

edited

github-actions bot commented Mar 2, 2024 •

edited

codesandbox-ci bot commented Mar 2, 2024 •

edited

codecov bot commented Mar 2, 2024 •

edited

socket-security bot commented Mar 26, 2024 •

edited

kiner-tang commented Mar 26, 2024

feat: Tag support aria-* in closable #47678

feat: Tag support aria-* in closable #47678

Conversation

kiner-tang commented Mar 2, 2024

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self-Check before Merge

stackblitz bot commented Mar 2, 2024

github-actions bot commented Mar 2, 2024 • edited

github-actions bot commented Mar 2, 2024 • edited

👁 Visual Regression Report for PR #47678 Failed ❌

github-actions bot commented Mar 2, 2024 • edited

size-limit report 📦

codesandbox-ci bot commented Mar 2, 2024 • edited

codecov bot commented Mar 2, 2024 • edited

Codecov Report

socket-security bot commented Mar 26, 2024 • edited

kiner-tang commented Mar 26, 2024

github-actions bot commented Mar 2, 2024 •

edited

github-actions bot commented Mar 2, 2024 •

edited

github-actions bot commented Mar 2, 2024 •

edited

codesandbox-ci bot commented Mar 2, 2024 •

edited

codecov bot commented Mar 2, 2024 •

edited

socket-security bot commented Mar 26, 2024 •

edited