Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AutoComplete size #4768

Merged
merged 4 commits into from
Feb 9, 2017
Merged

fix AutoComplete size #4768

merged 4 commits into from
Feb 9, 2017

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Feb 6, 2017 •
edited by afc163
Loading

@mention-bot
Copy link

@RaoHai, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui and @afc163 to be potential reviewers.

RaoHai
RaoHai commented Feb 6, 2017
View reviewed changes
components/auto-complete/style/index.less Outdated

&-lg {
.@{select-prefix-cls}-selection__placeholder {
top: 16px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑到可以配置一个 textarea 的情况，不能写 50%，故写像素。下同。

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.729% when pulling d4033f6 on RaoHai:AutocompleteSize into 0408c8c on ant-design:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.729% when pulling d4033f6 on RaoHai:AutocompleteSize into 0408c8c on ant-design:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.729% when pulling d4033f6 on RaoHai:AutocompleteSize into 0408c8c on ant-design:master.

ddcat1115
ddcat1115 reviewed Feb 6, 2017
View reviewed changes
components/auto-complete/style/index.less Outdated
&__placeholder {
margin-left: 8px;
margin-right: 8px;
top: 12px;
Copy link
Contributor

@ddcat1115 ddcat1115 Feb 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在的 AutoComplete 默认高度好像不对，只有25px，默认28px才对。
如果高度正确，这里应该是可以 @input-height-base / 2 这样子吧？lg 和 sm 也是类似

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.729% when pulling b8a2b90 on RaoHai:AutocompleteSize into 0408c8c on ant-design:master.

afc163
afc163 reviewed Feb 6, 2017
View reviewed changes
components/auto-complete/style/index.less Outdated
&:hover {
.hover;
.@{input-prefix-cls} {
border: 1px solid @border-color-base;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用这里的变量：#4734

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 81.742% when pulling c0c579e on RaoHai:AutocompleteSize into 0408c8c on ant-design:master.

@afc163
Copy link
Member

afc163 commented Feb 7, 2017

和日期相关的 snapshot test 挂了， @benjycui 看下。

@RaoHai RaoHai mentioned this pull request Feb 7, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 82.866% when pulling 8ee80dd on RaoHai:AutocompleteSize into 0408c8c on ant-design:master.

@ddcat1115 ddcat1115 merged commit fc3f4e1 into ant-design:master Feb 9, 2017
@RaoHai RaoHai mentioned this pull request Feb 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@ddcat1115 ddcat1115 ddcat1115 left review comments

Assignees

@ddcat1115 ddcat1115

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoComplete组件 BUG 升级到2.7后，AutoComplete组件size属性失效。
5 participants
@RaoHai @mention-bot @coveralls @afc163 @ddcat1115