Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: support ConfigProvider card bordered #47813

Closed
wants to merge 1 commit into from

Conversation

yee94
Copy link
Contributor

@yee94 yee94 commented Mar 11, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Card 组件的 bordered 是由 Props 进行控制,部分设计规范中,对于 Card 是不需要 border 的,为了满足此类需求,需要在 ConfigProvider 中添加全局控制。对已有使用场景不受影响。

📝 Changelog

Language Changelog
🇺🇸 English Support card bordered config in ConfigProvider
🇨🇳 Chinese Config Provider中支持卡边框配置

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 11, 2024

👁 Visual Regression Report for PR #47813 Failed ❌

🎯 Target branch: master (b6ad172)
📖 View Full Report ↗︎

Image name Expected Actual Diff
card-border-less.compact.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-border-less.compact.css-var.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-border-less.dark.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-border-less.dark.css-var.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-border-less.default.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-border-less.default.css-var.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-in-column.compact.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-in-column.compact.css-var.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-in-column.dark.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff
card-in-column.dark.css-var.png master: b6ad172a3d3e0b864e2d0102ac337a83c31feb5a current: pr-47813 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Preview failed

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@MadCcc
Copy link
Member

MadCcc commented Mar 11, 2024

新特性请提交 feature 分支

@yee94 yee94 closed this Mar 11, 2024
@yee94
Copy link
Contributor Author

yee94 commented Mar 11, 2024

新特性请提交 feature 分支

好的:#47817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants