Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: picker multiple selection lines collpase #47821

Merged
merged 3 commits into from Mar 11, 2024
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 11, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #47665
close #47683

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix DatePicker with multiple selector collapse for cross the line.
🇨🇳 Chinese 修复 DatePicker 设置 multiple 多选换行时,行与行之间没有间隙的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 11, 2024

👁 Visual Regression Report for PR #47821 Failed ❌

🎯 Target branch: master (bb567f6)
📖 View Full Report ↗︎

Image name Expected Actual Diff
date-picker-multiple.compact.png master: bb567f6831e75b82aeba1f091a8fc84ba70af631 current: pr-47821 diff
date-picker-multiple.compact.css-var.png master: bb567f6831e75b82aeba1f091a8fc84ba70af631 current: pr-47821 diff

Check Full Report for details

@zombieJ zombieJ changed the title Fix picker multiple selection lines collpase fix: picker multiple selection lines collpase Mar 11, 2024
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 334.46 KB (-12 B 🔽)
./dist/antd-with-locales.min.js 380.3 KB (-56 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb567f6) to head (da07388).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47821   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12644     12645    +1     
  Branches      3326      3326           
=========================================
+ Hits         12644     12645    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ
Copy link
Member Author

zombieJ commented Mar 11, 2024

看了一下截图对比。compact 下的标准大小新版是 28 是对的。以前小了 1px

@zombieJ zombieJ merged commit 7f87f91 into master Mar 11, 2024
110 of 111 checks passed
@zombieJ zombieJ deleted the fix-picker-multiple branch March 11, 2024 08:57
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* fix: DatePicker multiple padding

* docs: update demo

* chore: clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker 显示问题
2 participants