Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dutch locale and bumped dep versions so they include Dutch locales #4785

Merged
merged 2 commits into from
Feb 13, 2017

Conversation

corneyl
Copy link
Contributor

@corneyl corneyl commented Feb 7, 2017

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style. (N/A)
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Added Dutch locale and bumped dep versions so they include Dutch locales to:

  • rc-calendar to ~7.6.2
  • rc-pagination to ~1.6.6

Bumped versions so they include Dutch locales
- rc-calendar to ~7.6.2
- rc-pagination to ~1.6.6
@mention-bot
Copy link

@corneyl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @plandem, @benjycui and @afc163 to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 81.297% when pulling 0d800c0 on corneyl:add-dutch-locale into a39d435 on ant-design:master.

@benjycui
Copy link
Contributor

benjycui commented Feb 8, 2017

Sorry, could you PR to branch feature-2.8?

@corneyl corneyl changed the base branch from master to feature-2.8 February 8, 2017 08:52
@corneyl
Copy link
Contributor Author

corneyl commented Feb 8, 2017

Sure, I do not have to rebase right? feature-2.8 is even with master.

@afc163
Copy link
Member

afc163 commented Feb 8, 2017

@afc163
Copy link
Member

afc163 commented Feb 9, 2017

@corneyl

@corneyl
Copy link
Contributor Author

corneyl commented Feb 10, 2017

I will, but need some time, sorry.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 82.956% when pulling 3288eb8 on corneyl:add-dutch-locale into 5b14b4f on ant-design:feature-2.8.

@corneyl
Copy link
Contributor Author

corneyl commented Feb 10, 2017

Like this? Well that was quite easy...

@afc163
Copy link
Member

afc163 commented Feb 10, 2017

Yep, that make sure our coverage rate won't downgrade. 😸

@benjycui benjycui merged commit 2896185 into ant-design:feature-2.8 Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants