Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Badge align style with text under Space #47908

Merged
merged 1 commit into from Mar 16, 2024
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 16, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #47875

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge and text node align issue under Space.
🇨🇳 Chinese 修复 Badge 和文本元素在 Space 下排版不对齐的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 16, 2024

👁 Visual Regression Report for PR #47908 Failed ❌

🎯 Target branch: master (e0b57c5)
📖 View Full Report ↗︎

Image name Expected Actual Diff
badge-colorful-with-count-debug.compact.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-colorful-with-count-debug.compact.css-var.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-colorful.compact.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-colorful.compact.css-var.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-component-token.compact.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-component-token.compact.css-var.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-component-token.dark.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-component-token.dark.css-var.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-component-token.default.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff
badge-component-token.default.css-var.png master: e0b57c5773b2b53e0dff685679e971d33103caf9 current: pr-47908 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Mar 16, 2024

Preview is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 334.6 KB (-76 B 🔽)
./dist/antd-with-locales.min.js 380.58 KB (+97 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e0b57c5) to head (790582e).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47908   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12670     12670           
  Branches      3330      3330           
=========================================
  Hits         12670     12670           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit a8fb31c into master Mar 16, 2024
110 of 111 checks passed
@afc163 afc163 deleted the style/badge-align branch March 16, 2024 09:45
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge 独立使用时无法在垂直方向与其他组件/文字对齐
2 participants