Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix GetRef for some case #47983

Merged
merged 5 commits into from Mar 21, 2024
Merged

chore: fix GetRef for some case #47983

merged 5 commits into from Mar 21, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 20, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English misc: Fix GetRef ts util can not get correct ref type for some component.
🇨🇳 Chinese misc: 修复 GetRef 工具类型不能正确获得某些组件 ref 类型的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

👁 Visual Regression Report for PR #47983 Passed ✅

🎯 Target branch: master (f5e9d2d)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 20, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 334.59 KB
./dist/antd-with-locales.min.js 380.57 KB

Copy link

codesandbox-ci bot commented Mar 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

li-jia-nan
li-jia-nan previously approved these changes Mar 20, 2024
li-jia-nan
li-jia-nan previously approved these changes Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (31ff625) to head (a45759a).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47983   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12670     12765   +95     
  Branches      3330      3349   +19     
=========================================
+ Hits         12670     12765   +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan mentioned this pull request Mar 20, 2024
20 tasks
@afc163
Copy link
Member

afc163 commented Mar 20, 2024

看看文档在哪里透出一下?不然用户不知道这个 API

而且我们也不推荐直接 import _utils 下的东西。

@zombieJ
Copy link
Member Author

zombieJ commented Mar 21, 2024

li-jia-nan
li-jia-nan previously approved these changes Mar 21, 2024
li-jia-nan
li-jia-nan previously approved these changes Mar 21, 2024
@zombieJ zombieJ merged commit bd99546 into master Mar 21, 2024
106 checks passed
@zombieJ zombieJ deleted the fix-type branch March 21, 2024 07:55
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Mar 25, 2024
* chore: fix GetRef for some case

* test: add type test

* docs: add util doc

* fix: en

* chore: add logo
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* chore: fix GetRef for some case

* test: add type test

* docs: add util doc

* fix: en

* chore: add logo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants