Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change version selector position #4799

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Conversation

ddcat1115
Copy link
Contributor

to make it easier to be found.

2017-02-08 8 10 26

2017-02-08 8 11 19

@mention-bot
Copy link

@ddcat1115, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @benjycui and @pinggod to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.442% when pulling 1f31688 on ddcat1115:version-pos into 637c479 on ant-design:master.

@afc163
Copy link
Member

afc163 commented Feb 8, 2017

把语言切换也改成 select,然后再加个国旗好了。

@benjycui
Copy link
Contributor

benjycui commented Feb 9, 2017

其实只有两个语言时的语言切换,还是不要用 Select。

image

这样英文不好的人就真的不知道要点哪里了。。

@ddcat1115
Copy link
Contributor Author

😂 是的......加个国旗可能会好些,但是select更宽,目前 component search 都已经很难露脸了。。。。两种语言时就维持现状操作起来也更简单

@ddcat1115
Copy link
Contributor Author

先合了,后面有需要再改~

@ddcat1115 ddcat1115 merged commit 16ad027 into ant-design:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants