Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust the order of QRCode style prop #48053

Merged
merged 3 commits into from Mar 25, 2024
Merged

fix: adjust the order of QRCode style prop #48053

merged 3 commits into from Mar 25, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Mar 24, 2024 •
edited by MadCcc

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix QRCode that custom style would be overrided by internal style.
🇨🇳 Chinese 修复 QRCode 组件自定义样式会被内部样式覆盖的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2024 •
edited

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2024 •
edited

👁 Visual Regression Report for PR #48053 Passed ✅

🎯 Target branch: master (a4bf443)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@li-jia-nan li-jia-nan changed the title fix: adjust the order of style prop fix: adjust the order of QRCode style prop Mar 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2024 •
edited

size-limit report 📦

Path Size
./dist/antd.min.js 334.66 KB (-84 B 🔽)
./dist/antd-with-locales.min.js 380.48 KB (+81 B 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 24, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Mar 24, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (87debac) to head (4c46a6a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #48053   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12670     12671    +1     
  Branches      3326      3326           
=========================================
+ Hits         12670     12671    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member Author

@thinkasany 看一下这样有问题么？

crazyair
crazyair previously approved these changes Mar 25, 2024
View reviewed changes
@MadCcc
Copy link
Member

MadCcc commented Mar 25, 2024

加个测试用例

@crazyair
Copy link
Member

加个测试用例

snap 的变动就是测试，可以再加几个样式，健壮下目前的用例

@MadCcc
Copy link
Member

MadCcc commented Mar 25, 2024

加个测试用例

snap 的变动就是测试，可以再加几个样式，健壮下目前的用例

不要在 demo 里加样式了，写个 test case 测一下覆盖样式

@MadCcc MadCcc merged commit 7393623 into master Mar 25, 2024
106 checks passed
@MadCcc MadCcc deleted the fix-QRCode branch March 25, 2024 02:59
@github-actions GitHub Actions
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。

@li-jia-nan li-jia-nan mentioned this pull request Mar 25, 2024
Merged
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
@li-jia-nan
fix: adjust the order of QRCode style prop (ant-design#48053)
0ba5426 
* fix: adjust the order of style prop

* test: update snap

* test: add test case
@thinkasany thinkasany mentioned this pull request Mar 31, 2024
Open
20 tasks
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
@li-jia-nan @CooperHash
fix: adjust the order of QRCode style prop (ant-design#48053)
1d7aa7c 
* fix: adjust the order of style prop

* test: update snap

* test: add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadCcc MadCcc MadCcc approved these changes

@thinkasany thinkasany thinkasany approved these changes

@crazyair crazyair crazyair left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@li-jia-nan @MadCcc @crazyair @thinkasany