Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the animation of Menu smoother while expanding the Sider wh… #48127

Merged
merged 3 commits into from Apr 16, 2024

Conversation

metouch
Copy link
Contributor

@metouch metouch commented Mar 27, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#48121

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English make the animation of Menu smoother while expanding the Sider which embedded with a Menu
🇨🇳 Chinese 内嵌Menu的Sider在展开时,让Menu动画效果更加流畅

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 27, 2024

👁 Visual Regression Report for PR #48127 Passed ✅

🎯 Target branch: master (0a7e225)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Preview is ready

Copy link

codesandbox-ci bot commented Mar 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0a7e225) to head (364dfa8).

❗ Current head 364dfa8 differs from pull request most recent head 052d1da. Consider uploading reports for the commit 052d1da to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48127    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          744       736     -8     
  Lines        12880     12684   -196     
  Branches      3367      3326    -41     
==========================================
- Hits         12880     12684   -196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 2562852 into ant-design:master Apr 16, 2024
15 of 16 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@metouch metouch deleted the fixIssue48121 branch April 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants