Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): fix getValueProps shouldn't work when FormItem's name doesn't exist #48163

Merged
merged 1 commit into from Mar 29, 2024

Conversation

madocto
Copy link
Contributor

@madocto madocto commented Mar 29, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #47952

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 1. Fix getValueProps shouldn't work when FormItem's name doesn't exist . 2. Fix Form's setFieldsValue should tread same as setFields.
🇨🇳 Chinese 1. 修复当 FormItem 的 name 不存在时,getValueProps 不应该执行。2. 修复 Form 的 setFieldsValuesetFields 的行为应该相同。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 29, 2024

👁 Visual Regression Report for PR #48163 Passed ✅

🎯 Target branch: master (b0e4a3a)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@madocto madocto changed the title fix(Form): fix getValueProps shouldn't work when FormItem's name doesn't exist . fix(Form): fix getValueProps shouldn't work when FormItem's name doesn't exist Mar 29, 2024
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@li-jia-nan
Copy link
Member

这个改了 minor 版本,不需要放在 feature 分支么?

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 29, 2024

这个改了 minor 版本,不需要放在 feature 分支么?

rc-field-form@1.43.0 、rc-field-form@1.44.0 好像都是bugfix

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 29, 2024

change log 应该把 rc-field-form@1.43.0 、rc-field-form@1.44.0 的fix 都包含一下

@madocto
Copy link
Contributor Author

madocto commented Mar 29, 2024

done

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-field-form@1.44.0 environment 0 290 kB zombiej

🚮 Removed packages: npm/@types/fs-extra@11.0.4, npm/@types/gtag.js@0.0.19, npm/@types/http-server@0.12.4, npm/@types/inquirer@9.0.7, npm/@types/isomorphic-fetch@0.0.39, npm/@types/jest-axe@3.5.9, npm/@types/jest-environment-puppeteer@5.0.6, npm/@types/jest-image-snapshot@6.4.0, npm/@types/jest@29.5.12, npm/@types/jquery@3.5.29, npm/@types/jsdom@21.1.6, npm/@types/lodash@4.17.0, npm/@types/node@20.11.30, npm/@types/nprogress@0.2.3, npm/@types/pixelmatch@5.2.6, npm/@types/pngjs@6.0.4, npm/@types/prismjs@1.26.3, npm/@types/progress@2.0.7, npm/@types/qs@6.9.14, npm/@types/react-copy-to-clipboard@5.0.7, npm/@types/react-highlight-words@0.16.7, npm/@types/react-resizable@3.0.7, npm/@types/react@18.2.73, npm/@types/semver@7.5.8, npm/@types/tar@6.1.11, npm/@types/throttle-debounce@5.0.2, npm/@types/warning@3.0.3, npm/@typescript-eslint/eslint-plugin@7.4.0, npm/@typescript-eslint/parser@7.4.0, npm/ali-oss@6.20.0, npm/antd-img-crop@4.21.0, npm/antd-style@3.6.2, npm/antd-token-previewer@2.0.8, npm/chalk@4.1.2, npm/cheerio@1.0.0-rc.12, npm/circular-dependency-plugin@5.2.2, npm/cross-env@7.0.3, npm/cross-fetch@4.0.0, npm/crypto@1.0.1, npm/dekko@0.2.1, npm/dumi-plugin-color-chunk@1.1.0, npm/dumi@2.3.0-beta.8, npm/esbuild-loader@4.1.0, npm/eslint-config-airbnb@19.0.4, npm/eslint-config-prettier@9.1.0, npm/eslint-import-resolver-typescript@3.6.1, npm/eslint-plugin-compat@4.2.0, npm/eslint-plugin-import@2.29.1, npm/eslint-plugin-jest@27.9.0, npm/eslint-plugin-jsx-a11y@6.8.0, npm/eslint-plugin-lodash@7.4.0, npm/eslint-plugin-markdown@4.0.1, npm/eslint-plugin-react-hooks@4.6.0, npm/eslint-plugin-react@7.34.1, npm/eslint-plugin-unicorn@51.0.1, npm/eslint@8.57.0, npm/fetch-jsonp@1.3.0, npm/fs-extra@11.2.0, npm/gh-pages@6.1.1, npm/html2sketch@1.0.2, npm/http-server@14.1.1, npm/husky@9.0.11, npm/identity-obj-proxy@3.0.0, npm/immer@10.0.4, npm/inquirer@9.2.16, npm/is-ci@3.0.1, npm/isomorphic-fetch@3.0.0, npm/jest-axe@8.0.0, npm/jest-canvas-mock@2.5.2, npm/jest-environment-jsdom@29.7.0, npm/jest-environment-node@29.7.0, npm/jest-image-snapshot@6.4.0, npm/jest-puppeteer@10.0.1, npm/jest@29.7.0, npm/jquery@3.7.1, npm/jsdom@24.0.0, npm/jsonml-to-react-element@1.1.11, npm/jsonml.js@0.1.0, npm/lint-staged@15.2.2, npm/lodash@4.17.21, npm/lunar-typescript@1.7.5, npm/lz-string@1.5.0, npm/minimist@1.2.8, npm/mockdate@3.0.5, npm/node-fetch@3.3.2, npm/node-notifier@10.0.1, npm/nprogress@0.2.0, npm/open@10.1.0, npm/pixelmatch@5.3.0, npm/pngjs@7.0.0, npm/prettier-plugin-jsdoc@1.3.0, npm/prettier@3.2.5, npm/pretty-format@29.7.0, npm/prismjs@1.29.0, npm/progress@2.0.3, npm/puppeteer@22.6.1, npm/qs@6.12.0, npm/rc-field-form@1.42.1, npm/rc-footer@0.6.8, npm/rc-tween-one@3.0.6, npm/rc-virtual-list@3.11.4, npm/react-copy-to-clipboard@5.1.0, npm/react-countup@6.5.3, npm/react-draggable@4.4.6, npm/react-fast-marquee@1.6.4, npm/react-highlight-words@0.20.0, npm/react-infinite-scroll-component@6.1.0, npm/react-intersection-observer@9.8.1, npm/react-resizable@3.0.5, npm/react-router-dom@6.22.3, npm/react-sticky-box@2.0.5, npm/regenerator-runtime@0.14.1, npm/remark-cli@12.0.0, npm/remark-gfm@4.0.0, npm/remark-html@16.0.1, npm/remark-lint-no-undefined-references@4.2.1, npm/remark-lint@9.1.2, npm/remark-preset-lint-recommended@6.1.3, npm/remark@15.0.1, npm/runes2@1.1.4, npm/sharp@0.33.3, npm/simple-git@3.23.0, npm/size-limit@11.1.2, npm/stylelint-config-rational-order@0.1.2, npm/stylelint-config-standard@36.0.0, npm/stylelint-prettier@5.0.0, npm/stylelint@16.3.1, npm/sylvanas@0.6.1, npm/tar-fs@3.0.5, npm/tar@6.2.1, npm/terser@5.30.0, npm/tsx@4.7.1, npm/typedoc@0.25.12, npm/typescript@5.4.3, npm/vanilla-jsoneditor@0.23.1, npm/vanilla-tilt@1.8.1, npm/webpack-bundle-analyzer@4.10.1, npm/webpack@5.91.0, npm/xhr-mock@2.5.1

View full report↗︎

@zombieJ zombieJ merged commit 9ccb419 into ant-design:master Mar 29, 2024
68 checks passed
@madocto madocto deleted the fix-field-getValueProps branch March 29, 2024 07:45
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Mar 29, 2024
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Mar 29, 2024
@MadCcc MadCcc mentioned this pull request Mar 31, 2024
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants