Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: remove optionLabelProp #48186

Merged
merged 7 commits into from
Apr 1, 2024
Merged

demo: remove optionLabelProp #48186

merged 7 commits into from
Apr 1, 2024

Conversation

crazyair
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

这个 demo 已经用了 optionRender 就不需要 optionLabelProp

📝 Changelog

Language Changelog
🇺🇸 English demo
🇨🇳 Chinese demo

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 30, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 30, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.31 KB (+19 B 🔺)
./dist/antd-with-locales.min.js 383.43 KB (+106 B 🔺)

Copy link

codesandbox-ci bot commented Mar 31, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (287dd69) to head (57528b9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48186   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        12856     12856           
  Branches      3364      3364           
=========================================
  Hits         12856     12856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member

你这标题应该是 demo,不是 feat

@crazyair crazyair changed the title feat: remove optioLabelProp demo: remove optioLabelProp Mar 31, 2024
@crazyair crazyair changed the title demo: remove optioLabelProp demo: remove optionLabelProp Mar 31, 2024
@crazyair
Copy link
Member Author

你这标题应该是 demo,不是 feat

改了

@crazyair crazyair requested a review from afc163 April 1, 2024 01:03
@ant-design ant-design deleted a comment from github-actions bot Apr 1, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

👁 Visual Regression Report for PR #48186 Failed ❌

🎯 Target branch: master (3e7c9e5)
📖 View Full Report ↗︎

Image name Expected Actual Diff
select-option-label-prop.compact.png master: 3e7c9e5cc6e01107b92fc7b652c1bf15206bc5ba ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
select-option-label-prop.compact.css-var.png master: 3e7c9e5cc6e01107b92fc7b652c1bf15206bc5ba ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
select-option-label-prop.dark.png master: 3e7c9e5cc6e01107b92fc7b652c1bf15206bc5ba ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
select-option-label-prop.dark.css-var.png master: 3e7c9e5cc6e01107b92fc7b652c1bf15206bc5ba ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
select-option-label-prop.default.png master: 3e7c9e5cc6e01107b92fc7b652c1bf15206bc5ba ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
select-option-label-prop.default.css-var.png master: 3e7c9e5cc6e01107b92fc7b652c1bf15206bc5ba ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨

Check Full Report for details

@afc163
Copy link
Member

afc163 commented Apr 1, 2024

ci 挂了

@afc163 afc163 merged commit ff231ab into master Apr 1, 2024
105 of 106 checks passed
@afc163 afc163 deleted the remove-option-label-prop branch April 1, 2024 03:09
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
* feat: remove optioLabelProp

* feat: doc

* feat: doc

* feat: option-render

* feat: option-render

* feat: snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants