Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'middle' as a valid value for Table.props.size #4819

Merged
merged 1 commit into from
Feb 9, 2017

Conversation

wms
Copy link
Contributor

@wms wms commented Feb 9, 2017

Dynamic settings at https://ant.design/components/table/#components-table-demo-dynamic-settings indicate that 'middle' is a valid option for Table.props.size, but this value is not valid according to the Table.Props interface, so I've added it.

--

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@mention-bot
Copy link

@warrenseymour, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @benjycui and @yesmeck to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.481% when pulling dd16c70 on FountainheadTechnologies:add-middle-table-size into 16ad027 on ant-design:master.

@yesmeck yesmeck merged commit 7010dd0 into ant-design:master Feb 9, 2017
@yesmeck
Copy link
Member

yesmeck commented Feb 9, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants