Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table的loading可以使用Spin的属性 #4824

Merged
merged 4 commits into from
Feb 13, 2017
Merged

Table的loading可以使用Spin的属性 #4824

merged 4 commits into from
Feb 13, 2017

Conversation

lixiaoyang1992
Copy link
Contributor

@lixiaoyang1992 lixiaoyang1992 commented Feb 10, 2017

Close: #4544

@mention-bot
Copy link

@lixiaoyang1992, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @benjycui and @afc163 to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.866% when pulling 094dfd4 on lixiaoyang1992:table-spin into 5b14b4f on ant-design:feature-2.8.

@lixiaoyang1992
Copy link
Contributor Author

#4544

@yesmeck
Copy link
Member

yesmeck commented Feb 10, 2017

@lixiaoyang1992 写下测试吧

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.866% when pulling 065677d on lixiaoyang1992:table-spin into 5b14b4f on ant-design:feature-2.8.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.866% when pulling f02ebe3 on lixiaoyang1992:table-spin into 5b14b4f on ant-design:feature-2.8.

loading = {{
spinning: this.state.loading,
delay: 500
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.866% when pulling 643ee4b on lixiaoyang1992:table-spin into 5b14b4f on ant-design:feature-2.8.

@afc163
Copy link
Member

afc163 commented Feb 10, 2017

👍 赞赞赞

@@ -872,10 +876,16 @@ export default class Table<T> extends React.Component<TableProps<T>, any> {
const paginationPatchClass = (this.hasPagination() && data && data.length !== 0)
? `${prefixCls}-with-pagination`
: `${prefixCls}-without-pagination`;
let loading = this.props.loading;
if (typeof (loading) === 'boolean') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实不懂这里为什么有括号。。

@benjycui benjycui merged commit d05a03f into ant-design:feature-2.8 Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants