Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: Upload demo add margin #48268

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Conversation

CooperHash
Copy link
Contributor

@CooperHash CooperHash commented Apr 4, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#48091

💡 Background and solution

after remove margin to flex
Upload's avatar.tsx demo needs manual spacing adjustment.

before:
image

after:
image

📝 Changelog

Language Changelog
🇺🇸 English add margin to upload demo
🇨🇳 Chinese 新增upload demo间距

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

👁 Visual Regression Report for PR #48268 Failed ❌

🎯 Target branch: master (7e6678a)
📖 View Full Report ↗︎

Image name Expected Actual Diff
input-presuffix.compact.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
input-presuffix.compact.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
input-presuffix.dark.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
input-presuffix.dark.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
input-presuffix.default.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
input-presuffix.default.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
upload-avatar.compact.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
upload-avatar.compact.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
upload-avatar.dark.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff
upload-avatar.dark.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48268 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Preview is ready

Copy link

codesandbox-ci bot commented Apr 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@li-jia-nan li-jia-nan changed the title fix: Upload demo add margin demo: Upload demo add margin Apr 4, 2024
@li-jia-nan
Copy link
Member

需要更新一下快照

@li-jia-nan
Copy link
Member

快照还是有问题,看一下 CI 哪里挂了

@CooperHash
Copy link
Contributor Author

貌似是preview?

@CooperHash
Copy link
Contributor Author

暂时没看出问题在哪

@li-jia-nan
Copy link
Member

image

@li-jia-nan
Copy link
Member

执行一下 npm run test:update components/upload

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f427c87) to head (9190c40).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        12855     12855           
  Branches      3365      3365           
=========================================
  Hits         12855     12855           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit db822fd into ant-design:master Apr 5, 2024
61 of 62 checks passed
@CooperHash CooperHash deleted the fix-upload-docs branch April 5, 2024 07:33
CooperHash added a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
* fix: Upload add demo marigin

* use Flex and update Snap

* update snap

---------

Co-authored-by: lijianan <574980606@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants