-
-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo: Upload demo add margin #48268
demo: Upload demo add margin #48268
Conversation
|
👁 Visual Regression Report for PR #48268 Failed ❌
Check Full Report for details |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
需要更新一下快照 |
快照还是有问题,看一下 CI 哪里挂了 |
貌似是preview? |
暂时没看出问题在哪 |
执行一下 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48268 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 743 743
Lines 12855 12855
Branches 3365 3365
=========================================
Hits 12855 12855 ☔ View full report in Codecov by Sentry. |
* fix: Upload add demo marigin * use Flex and update Snap * update snap --------- Co-authored-by: lijianan <574980606@qq.com>
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#48091
💡 Background and solution
after remove margin to flex
Upload's avatar.tsx demo needs manual spacing adjustment.
before:
![image](https://private-user-images.githubusercontent.com/73218815/319525813-65d0a677-037f-4e7b-94da-7f3010d3582f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3NjMxMDcsIm5iZiI6MTcxOTc2MjgwNywicGF0aCI6Ii83MzIxODgxNS8zMTk1MjU4MTMtNjVkMGE2NzctMDM3Zi00ZTdiLTk0ZGEtN2YzMDEwZDM1ODJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDE1NTMyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJmMDhiNjYwMjAwNjk3NzBkYTZlMzUwMmYxNTE1M2YxMzY2MGUyOTAzNTgyYjZiNjliZTNhZTgyOGNkYzY4NzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QuV4zasJRpyjby_HHLAu7kECEhv8F-j4opnWnO9zqIU)
after:
![image](https://private-user-images.githubusercontent.com/73218815/319525955-31fad7a9-541e-4530-a04a-258a96090ea7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3NjMxMDcsIm5iZiI6MTcxOTc2MjgwNywicGF0aCI6Ii83MzIxODgxNS8zMTk1MjU5NTUtMzFmYWQ3YTktNTQxZS00NTMwLWEwNGEtMjU4YTk2MDkwZWE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDE1NTMyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM5ZTQ1ZDdhMjNhZDgzZTExY2Q1OGU1ZDRjMmY0MzFjY2FjNTMxYTAwYWQ0MjYxN2NmYzYwMjg1NjBhODFmODUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.D1CL0F4-MzUj-vCKt2PnAuAQvOn4rsjcygmEm6XWIhU)
📝 Changelog
☑️ Self-Check before Merge