Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: simplify bug reason & adjust padding #48277

Merged
merged 2 commits into from
Apr 5, 2024
Merged

site: simplify bug reason & adjust padding #48277

merged 2 commits into from
Apr 5, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Apr 4, 2024 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

before:

image

after:

image

📝 Changelog

Language Changelog
🇺🇸 English site: simplify bug reason & adjust padding
🇨🇳 Chinese site: simplify bug reason & adjust padding

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024 •
edited

👁 Visual Regression Report for PR #48277 Failed ❌

🎯 Target branch: master (7e6678a)
📖 View Full Report ↗︎

Image name Expected Actual Diff
input-presuffix.compact.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48277 diff
input-presuffix.compact.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48277 diff
input-presuffix.dark.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48277 diff
input-presuffix.dark.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48277 diff
input-presuffix.default.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48277 diff
input-presuffix.default.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48277 diff

Check Full Report for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024 •
edited

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024 •
edited

size-limit report 📦

Path Size
./dist/antd.min.js 336.38 KB
./dist/antd-with-locales.min.js 383.51 KB

@li-jia-nan li-jia-nan changed the title site: simplify bug reason site: simplify bug reason & adjust padding Apr 4, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 4, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f427c87) to head (71c01c7).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #48277   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        12855     12855           
  Branches      3365      3365           
=========================================
  Hits         12855     12855

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang
Copy link
Member

image 还会有这种情况，可能定位的目标点是某个 issue 的某个 comment，如果改成 id 的话，看起来有点怪怪的，可以在展示的的时候，先将 url 中的 issue id 或 pr id 提取出来展示

@li-jia-nan
Copy link
Member Author

可以在展示的的时候，先将 url 中的 issue id 或 pr id 提取出来展示

这个是什么意思？没明白呢

@kiner-tang
Copy link
Member

可以在展示的的时候，先将 url 中的 issue id 或 pr id 提取出来展示

这个是什么意思？没明白呢

就是我们的 bug 链接里面，包含了后面的哈希，感觉展示的时候可以去掉，跳转的时候保留就可以

@li-jia-nan
Copy link
Member Author

就是我们的 bug 链接里面，包含了后面的哈希，感觉展示的时候可以去掉，跳转的时候保留就可以

这个正则我不会写，让我想想

@li-jia-nan
Copy link
Member Author

就是我们的 bug 链接里面，包含了后面的哈希，感觉展示的时候可以去掉，跳转的时候保留就可以

要不你来改一下？

@kiner-tang
Copy link
Member

就是我们的 bug 链接里面，包含了后面的哈希，感觉展示的时候可以去掉，跳转的时候保留就可以

要不你来改一下？

我来改一下

@kiner-tang
Update .dumi/theme/common/ComponentChangelog/ComponentChangelog.tsx
71c01c7 
Signed-off-by: kiner-tang <1127031143@qq.com>
@li-jia-nan li-jia-nan merged commit 448cb81 into master Apr 5, 2024
103 of 104 checks passed
@li-jia-nan li-jia-nan deleted the log-update branch April 5, 2024 03:41
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
@li-jia-nan @kiner-tang @CooperHash
site: simplify bug reason & adjust padding (ant-design#48277)
4f2c527 
* site: simplify bug reason

* Update .dumi/theme/common/ComponentChangelog/ComponentChangelog.tsx

Signed-off-by: kiner-tang <1127031143@qq.com>

---------

Signed-off-by: kiner-tang <1127031143@qq.com>
Co-authored-by: kiner-tang <1127031143@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiner-tang kiner-tang kiner-tang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@li-jia-nan @kiner-tang