Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use css token #48311

Merged
merged 3 commits into from Apr 7, 2024
Merged

refactor: use css token #48311

merged 3 commits into from Apr 7, 2024

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactor: use css token
🇨🇳 Chinese refactor: 使用 css token 替换 css 常量

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 7, 2024

👁 Visual Regression Report for PR #48311 Failed ❌

🎯 Target branch: master (7e6678a)
📖 View Full Report ↗︎

Image name Expected Actual Diff
input-presuffix.compact.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
input-presuffix.compact.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
input-presuffix.dark.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
input-presuffix.dark.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
input-presuffix.default.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
input-presuffix.default.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
upload-avatar.compact.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
upload-avatar.compact.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
upload-avatar.dark.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff
upload-avatar.dark.css-var.png master: 7e6678aa5146311855f3f4fc320a652768a20dae current: pr-48311 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 7, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 7, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.33 KB (-128 B 🔽)
./dist/antd-with-locales.min.js 383.45 KB (+103 B 🔺)

Copy link

codesandbox-ci bot commented Apr 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

kiner-tang
kiner-tang previously approved these changes Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (47e46fa) to head (70843dd).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        12855     12855           
  Branches      3365      3365           
=========================================
  Hits         12855     12855           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member Author

@li-jia-nan li-jia-nan merged commit 52df99f into master Apr 7, 2024
105 of 106 checks passed
@li-jia-nan li-jia-nan deleted the wave-motionDurationSlow branch April 7, 2024 07:36
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
* refactor: use css token

* style: update
@li-jia-nan li-jia-nan mentioned this pull request Apr 13, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants