Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typography expanded should not break lines #48340

Merged
merged 1 commit into from Apr 8, 2024
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 8, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48200

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography using ellipsis config with expandable=collapsible and row=1 at both time will make ellipsis not working as expect.
🇨🇳 Chinese 修复 Typography 的 ellipsis 同时配置 expandable=collapsiblerow=1 时,不会正确省略的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 8, 2024

👁 Visual Regression Report for PR #48340 Failed ❌

🎯 Target branch: master (4a25c9f)
📖 View Full Report ↗︎

Image name Expected Actual Diff
steps-label-placement.compact.css-var.png master: 4a25c9f5051f900d5b0f3568b21becc265e09698 current: pr-48340 diff
steps-label-placement.dark.css-var.png master: 4a25c9f5051f900d5b0f3568b21becc265e09698 current: pr-48340 diff
steps-label-placement.default.css-var.png master: 4a25c9f5051f900d5b0f3568b21becc265e09698 current: pr-48340 diff
steps-progress-debug.dark.css-var.png master: 4a25c9f5051f900d5b0f3568b21becc265e09698 current: pr-48340 diff
steps-progress.compact.css-var.png master: 4a25c9f5051f900d5b0f3568b21becc265e09698 current: pr-48340 diff

Check Full Report for details

Copy link

codesandbox-ci bot commented Apr 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.51 KB (+141 B 🔺)
./dist/antd-with-locales.min.js 383.39 KB (-158 B 🔽)

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a125dfe) to head (d193beb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #48340     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          743       744      +1     
  Lines        12855     14904   +2049     
  Branches      3365      3925    +560     
===========================================
+ Hits         12855     14904   +2049     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 61c8a43 into master Apr 8, 2024
106 of 107 checks passed
@zombieJ zombieJ deleted the fix-typography branch April 8, 2024 15:00
@PeachScript PeachScript mentioned this pull request Apr 13, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragraph一行时展开后显示不正确
2 participants