Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrap prop support boolean #48391

Merged
merged 12 commits into from Apr 11, 2024
Merged

feat: wrap prop support boolean #48391

merged 12 commits into from Apr 11, 2024

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: wrap prop support boolean
🇨🇳 Chinese Flex 组件 wrap 参数支持 boolean

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

👁 Visual Regression Report for PR #48391 Failed ❌

🎯 Target branch: feature (6a7945d)
📖 View Full Report ↗︎

Image name Expected Actual Diff
steps-label-placement.compact.css-var.png feature: 6a7945d2fd2d35cd9c9aa17f5e6c0d36f7342c71 current: pr-48391 diff
steps-label-placement.dark.css-var.png feature: 6a7945d2fd2d35cd9c9aa17f5e6c0d36f7342c71 current: pr-48391 diff
steps-label-placement.default.css-var.png feature: 6a7945d2fd2d35cd9c9aa17f5e6c0d36f7342c71 current: pr-48391 diff
steps-progress-debug.dark.css-var.png feature: 6a7945d2fd2d35cd9c9aa17f5e6c0d36f7342c71 current: pr-48391 diff
steps-progress.compact.css-var.png feature: 6a7945d2fd2d35cd9c9aa17f5e6c0d36f7342c71 current: pr-48391 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Preview is ready

components/flex/utils.ts Outdated Show resolved Hide resolved
components/flex/utils.ts Outdated Show resolved Hide resolved
components/flex/utils.ts Outdated Show resolved Hide resolved
Copy link

codesandbox-ci bot commented Apr 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

components/flex/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Apr 11, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.99 KB (+365 B 🔺)
./dist/antd-with-locales.min.js 383.86 KB (+120 B 🔺)

components/flex/utils.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6a7945d) to head (22c8f01).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48391   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12888     12887    -1     
  Branches      3379      3381    +2     
=========================================
- Hits         12888     12887    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/flex/utils.ts Outdated Show resolved Hide resolved
components/flex/utils.ts Outdated Show resolved Hide resolved
components/flex/utils.ts Outdated Show resolved Hide resolved
components/flex/utils.ts Outdated Show resolved Hide resolved
crazyair
crazyair previously approved these changes Apr 11, 2024
components/flex/utils.ts Outdated Show resolved Hide resolved
@li-jia-nan li-jia-nan requested a review from MadCcc April 11, 2024 13:52
@crazyair
Copy link
Member

wrap 的类型收窄,以及其他的地方的写法可以后续优化

@li-jia-nan
Copy link
Member Author

wrap 的类型收窄,以及其他的地方的写法可以后续优化

这个感觉得在群里讨论一下,问问大佬们要不要支持

@crazyair
Copy link
Member

wrap 的类型收窄,以及其他的地方的写法可以后续优化

这个感觉得在群里讨论一下,问问大佬们要不要支持

目前是写了是没效果的,对用户有心智负担。要不就支持,要不就收窄。可以问问

@li-jia-nan li-jia-nan merged commit a09b9dd into feature Apr 11, 2024
102 of 103 checks passed
@li-jia-nan li-jia-nan deleted the flex-support-wrap branch April 11, 2024 14:29
@li-jia-nan li-jia-nan mentioned this pull request Apr 11, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants