New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optimize CascaderProps #48420
feat: Optimize CascaderProps #48420
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Visual Regression Build for PR #48420 Failed ❌Potential causes:
|
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
怎么会大这么多 |
都是改的 ts,一行 js 代码也没改,最后的产物也没 ts |
感觉需要同步一下 |
feature 没有需要同步的 |
那没道理。。。js 没变化不应有尺寸变化的 |
可能是 rc-cascader 开启了 strict,代码加上了 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #48420 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 744 744
Lines 12887 12887
Branches 3381 3382 +1
=========================================
Hits 12887 12887 ☔ View full report in Codecov by Sentry. |
有可能,得回去看看。理论上以前没有 |
这个又挂了? |
趁现在还没正式对外,CascaderProps<Option, 'value', true> 这个按照使用频率,想把 multiple 改前面,改成 CascaderProps<Option, true, 'value'>,这样大部分场景只需要设置 CascaderProps or CascaderProps<Option, true> 主要看 fieldNames 和 multiple 哪个使用频率高 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge