Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: fix tar esm issue #48442

Merged
merged 2 commits into from Apr 14, 2024
Merged

scripts: fix tar esm issue #48442

merged 2 commits into from Apr 14, 2024

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Apr 14, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English ----
🇨🇳 Chinese ----

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Signed-off-by: vagusX <vagusxl@gmail.com>
Copy link

stackblitz bot commented Apr 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vagusX vagusX requested a review from zombieJ April 14, 2024 01:49
Copy link

codesandbox-ci bot commented Apr 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Apr 14, 2024

👁 Visual Regression Report for PR #48442 Failed ❌

🎯 Target branch: master (72b5263)
📖 View Full Report ↗︎

Image name Expected Actual Diff
steps-label-placement.compact.css-var.png master: 72b5263344bc2727d3dc8df3f3d57a5edc7739e9 current: pr-48442 diff
steps-label-placement.dark.css-var.png master: 72b5263344bc2727d3dc8df3f3d57a5edc7739e9 current: pr-48442 diff
steps-label-placement.default.css-var.png master: 72b5263344bc2727d3dc8df3f3d57a5edc7739e9 current: pr-48442 diff
steps-progress-debug.dark.css-var.png master: 72b5263344bc2727d3dc8df3f3d57a5edc7739e9 current: pr-48442 diff
steps-progress.compact.css-var.png master: 72b5263344bc2727d3dc8df3f3d57a5edc7739e9 current: pr-48442 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 14, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 14, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.49 KB
./dist/antd-with-locales.min.js 383.64 KB

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72b5263) to head (59330c7).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48442   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12875     12875           
  Branches      3366      3366           
=========================================
  Hits         12875     12875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: vagusX <vagusxl@gmail.com>
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1,visual diff 看起来是符合期望的,ref #48251

@PeachScript PeachScript merged commit 0072587 into master Apr 14, 2024
103 of 104 checks passed
@PeachScript PeachScript deleted the vagusX-patch-1 branch April 14, 2024 03:09
@PeachScript PeachScript mentioned this pull request Apr 14, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants